7904058: Enable BenchmarkParams construction to be overriden #160
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It enables Fibula to construct BenchmarkParams instances with some custom field values that are required for native mode. * Some reflection might still needed to adjust fields. E.g with PGO where the executable to instrument, and the optimized executable are located in different paths.
|
👋 Welcome back galder! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
This was referenced Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second in a series of PRs that I will be sending over the next few days, which make extending JMH to benchmark Java code running as GraalVM native images more easily. The codename for this extension is Fibula. It can still work without this PRs but without them the extension has to duplicate code that exists in JMH, which is not desirable.
This PR enables
BenchmarkParamsconstruction to be overriden, in order to easily support JMH use case for benchmarking native images. The JIRA contains a detailed explanation. Having this PR in simplifies construction ofBenchmarkParamsinstance. The changes galderz/fibula@8fd8cf3#diff-601b6d98eff18db8a804efb415d515c3d397d42b9c982713b72c37bea2ebbf18 demonstrate the simplification enabled by the changes here.Here is the PR list for reference:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmh.git pull/160/head:pull/160$ git checkout pull/160Update a local copy of the PR:
$ git checkout pull/160$ git pull https://git.openjdk.org/jmh.git pull/160/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 160View PR using the GUI difftool:
$ git pr show -t 160Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmh/pull/160.diff
Using Webrev
Link to Webrev Comment