Connection validation and making expires_at optional #244
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 40a6400 in 2 minutes and 24 seconds
More details
- Looked at
89lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/api/proxyHandler.ts:17
- Draft comment:
Theexpires_atfield is now optional in thezOauthCredentialsschema, but this code assumes it is always present. Consider handling the case whereexpires_atis undefined to avoid potential runtime errors. - Reason this comment was not posted:
Comment looked like it was already resolved.
Workflow ID: wflow_z30jVbX9rgx38nUV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on a0e3eaa in 39 seconds
More details
- Looked at
63lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_9zSk6wCSJgv6MEqP
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -205,15 +208,16 @@ export function makeDBService({ | |||
| return zRaw.pipeline.parse(pipe) | |||
| }) | |||
|
|
|||
| const getConnectionExpandedOrFail = (id: Id['conn']) => | |||
| const getConnectionExpandedOrFail = (id: Id['conn'], skipValidation = false) => | |||
| getConnectionOrFail(id).then(async (conn) => { | |||
There was a problem hiding this comment.
The getConnectionExpandedOrFail function should pass the skipValidation parameter to getConnectionOrFail to ensure consistent behavior.
| getConnectionOrFail(id).then(async (conn) => { | |
| getConnectionOrFail(id, skipValidation) |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d069ddc in 35 seconds
More details
- Looked at
122lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. packages/engine-backend/services/dbService.ts:213
- Draft comment:
TheskipValidationparameter should be passed togetConnectionOrFailto ensure consistent behavior when validation is skipped. Please update the call togetConnectionOrFail(id, skipValidation). - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_dWBk4LFDjqFUIECl
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Enhances connection validation by introducing optional
expires_atin OAuth credentials and adding askipValidationparameter for flexible schema validation.zOauthCredentialsschema inoauthConnector.tsto handle optionalexpires_atin OAuth credentials.proxyHandler.tsto check for optionalexpires_atin credentials.connectionRouter.tsto passtrueforskipValidationingetConnectionOrFail()andgetConnectionExpandedOrFail().skipValidationparameter togetConnectorConfigOrFail(),getIntegrationOrFail(),getConnectionOrFail(),getPipelineOrFail(),getConnectionExpandedOrFail(), andgetPipelineExpandedOrFail()indbService.ts.skipValidationto bypass schema validation when necessary.oauthConnector.tsto usezOauthCredentialsinoauthBaseSchema.proxyHandler.tsforcredentialsExpiredcheck.This description was created by
for d069ddc. It will automatically update as commits are pushed.