adding skip validation to fetch connection, used for delete

Author: pellicceama

packages/engine-backend/router/connectionRouter.ts

@@ -262,9 +262,9 @@ export const connectionRouter = trpc.router({
     .output(z.object({}))
     .mutation(async ({input: {id: connId, ...opts}, ctx}) => {
       if (ctx.viewer.role === 'customer') {
-        await ctx.services.getConnectionOrFail(connId)
+        await ctx.services.getConnectionOrFail(connId, true)
       }
-      const conn = await ctx.asOrgIfNeeded.getConnectionExpandedOrFail(connId)
+      const conn = await ctx.asOrgIfNeeded.getConnectionExpandedOrFail(connId, true)
       const {settings, connectorConfig: ccfg} = conn
       if (!opts?.skipRevoke) {
         await ccfg.connector.revokeConnection?.(

packages/engine-backend/services/dbService.ts

@@ -184,15 +184,18 @@ export function makeDBService({
       }
       return zRaw.integration.parse(ins)
     })
-  const getConnectionOrFail = (id: Id['conn']) =>
+  const getConnectionOrFail = (id: Id['conn'], skipValidation = false) =>
     metaService.tables.connection.get(id).then((conn) => {
       if (!conn) {
         throw new TRPCError({
           code: 'NOT_FOUND',
           message: `conn not found: ${id}`,
         })
       }
-      return zRaw.connection.parse(conn)
+      if (!skipValidation) {
+        return zRaw.connection.parse(conn)
+      }
+      return conn
     })
   const getPipelineOrFail = (id: Id['pipe']) =>
     metaService.tables.pipeline.get(id).then((pipe) => {
@@ -205,15 +208,16 @@ export function makeDBService({
       return zRaw.pipeline.parse(pipe)
     })
 
-  const getConnectionExpandedOrFail = (id: Id['conn']) =>
+  const getConnectionExpandedOrFail = (id: Id['conn'], skipValidation = false) =>
     getConnectionOrFail(id).then(async (conn) => {
       const connectorConfig = await getConnectorConfigOrFail(
         conn.connectorConfigId,
       )
-      const settings: {} =
-        connectorConfig.connector.schemas.connectionSettings?.parse(
-          conn.settings,
-        )
+      const settings: {} = skipValidation
+        ? conn.settings
+        : connectorConfig.connector.schemas.connectionSettings?.parse(
+            conn.settings,
+          )
       const integration = conn.integrationId
         ? await getIntegrationOrFail(conn.integrationId)
         : undefined