fix/248-depr-karma-selenium-webdriver-launcher

[tonybusa]

…commented out the webpack test from the LMS karma config

Description

This change request address the issue: openedx/public-engineering#248 by removing the reference to karma-selenium-webdriver-launcher in the package.json and the karma configs. I also took it a step further to comment out the tests in the lms/static/karma_lms.conf.js that reference webpack:

  // Define the Webpack-built spec files first
   {pattern: 'course_experience/js/**/*_spec.js', webpack: true},
   {pattern: 'js/learner_dashboard/**/*_spec.js', webpack: true},
   {pattern: 'js/student_account/components/**/*_spec.js', webpack: true},
   {pattern: 'completion/js/**/*_spec.js', webpack: true},

so that we could potentially have more code coverage if deemed useful. Otherwise, we may want to go through and delete all spec files within the LMS folder since they aren't being run, and/or maintained.

Useful information to include:

• This would affect "Developer"s and would need to reinstall their node_modules.
• If the CI passes, and we make a decision on the LMS tests, we could likely delete the commented lines in the PR, or reference the Fix and re-enable tests for legacy Webpack-built JS #35956 as a follow up to this PR.

Supporting information

Original issue: openedx/public-engineering#248
Follow up issue: #35956

Testing instructions

These affect tests that run in the CI on a linux machine. Unable to run the npm commands locally on my mac machine.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

• Does this change depend on other changes elsewhere?
• Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
• If your database migration can't be rolled back easily.

[openedx-webhooks]

Thanks for the pull request, @tonybusa!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

• If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
  • This process (including the steps you'll need to take) is documented here.
• If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

• Dependencies

  This PR must be merged before / after / at the same time as ...

• Blockers

  This PR is waiting for OEP-1234 to be accepted.

• Timeline information

  This PR must be merged by XX date because ...

• Partner information

  This is for a course on edx.org.

• Supporting documentation
• Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

---

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

• Overview of Review Process for Community Contributions
• Pull Request Status Guide
• Making changes to your pull request

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

• The size and impact of the changes that it introduces
• The need for product review
• Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.