-
Notifications
You must be signed in to change notification settings - Fork 4k
feat: Add new publish fields on container search document [FC-0083] #36551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add new publish fields on container search document [FC-0083] #36551
Conversation
Thanks for the pull request, @ChrisChV! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
23d8f40
to
b5f0e06
Compare
* `punlish_display_name` and `last_published`
b5f0e06
to
0a18a26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This works as described, thank you @ChrisChV :)
- I tested this using my tutor dev stack
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A -
User-facing strings are extracted for translationN/A
2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production. |
2U Release Notice: This PR has been deployed to the edX production environment. |
1 similar comment
2U Release Notice: This PR has been deployed to the edX production environment. |
* Added publish_display_name and last_published on container search document. * This change is used in feat: Add unit from library in course [FC-0083] frontend-app-authoring#1829 to show only published units in the unit picker, also to show the published_display_name in the picker, and avoid empty titles. * Which edX user roles will this change impact? "Developer".
* Added publish_display_name and last_published on container search document. * This change is used in feat: Add unit from library in course [FC-0083] frontend-app-authoring#1829 to show only published units in the unit picker, also to show the published_display_name in the picker, and avoid empty titles. * Which edX user roles will this change impact? "Developer".
Description
publish_display_name
andlast_published
on container search document.published_display_name
in the picker, and avoid empty titles.Supporting information
Testing instructions
tutor dev exec cms ./manage.py cms reindex_studio --experimental
last_published
fieldlast_published
field as null.published.display_name
field and thelast_published
field is updated.Deadline
ASAP, before Teak.
Other information
N/A