Skip to content

feat: Add new publish fields on container search document [FC-0083] #36551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChrisChV
Copy link
Contributor

@ChrisChV ChrisChV commented Apr 18, 2025

Description

Supporting information

Testing instructions

  • If you have units created in libraries, run tutor dev exec cms ./manage.py cms reindex_studio --experimental
  • Go to Meilisearch and verify that your units have the last_published field
  • Go to the library home of a library
  • Create a new unit in the library.
  • Go to Meilisearch and verify that your new unit has the last_published field as null.
  • Publish your unit.
  • Go to Meilisearch and verify that your unit has the published.display_name field and the last_published field is updated.

Deadline

ASAP, before Teak.

Other information

N/A

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 18, 2025

Thanks for the pull request, @ChrisChV!

This repository is currently maintained by @openedx/wg-maintenance-edx-platform.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 18, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Apr 18, 2025
@ChrisChV ChrisChV force-pushed the chris/FAL-4070-published-display-name-on-index branch from 23d8f40 to b5f0e06 Compare April 18, 2025 15:52
@ChrisChV ChrisChV marked this pull request as draft April 18, 2025 15:53
@ChrisChV ChrisChV changed the title feat: Add new publish field on container search document feat: Add new publish field on container search document [FC-0083] Apr 18, 2025
* `punlish_display_name` and `last_published`
@ChrisChV ChrisChV force-pushed the chris/FAL-4070-published-display-name-on-index branch from b5f0e06 to 0a18a26 Compare April 18, 2025 16:19
@ChrisChV ChrisChV changed the title feat: Add new publish field on container search document [FC-0083] feat: Add new publish fields on container search document [FC-0083] Apr 21, 2025
@ChrisChV ChrisChV marked this pull request as ready for review April 21, 2025 21:37
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This works as described, thank you @ChrisChV :)

  • I tested this using my tutor dev stack
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@ChrisChV ChrisChV enabled auto-merge (squash) April 22, 2025 16:38
@ChrisChV ChrisChV merged commit f5e0500 into openedx:master Apr 22, 2025
48 checks passed
@ChrisChV ChrisChV deleted the chris/FAL-4070-published-display-name-on-index branch April 22, 2025 16:58
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Apr 22, 2025
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

tonybusa pushed a commit to tonybusa/edx-platform that referenced this pull request Apr 23, 2025
* Added publish_display_name and last_published on container search document.
* This change is used in feat: Add unit from library in course [FC-0083] frontend-app-authoring#1829 to show only published units in the unit picker, also to show the published_display_name in the picker, and avoid empty titles.
* Which edX user roles will this change impact? "Developer".
UsamaSadiq pushed a commit that referenced this pull request May 14, 2025
* Added publish_display_name and last_published on container search document.
* This change is used in feat: Add unit from library in course [FC-0083] frontend-app-authoring#1829 to show only published units in the unit picker, also to show the published_display_name in the picker, and avoid empty titles.
* Which edX user roles will this change impact? "Developer".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants