Skip to content

Remove py2neo dependency #36586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Remove py2neo dependency #36586

merged 1 commit into from
Apr 23, 2025

Conversation

ormsbee
Copy link
Contributor

@ormsbee ormsbee commented Apr 23, 2025 •
edited
Loading 

The py2neo package exists to support CourseGraph, which required the
Neo4j database. Support for it was removed before the Sumac cut, tracked
by the following DEPR:
  https://github.com/openedx/edx-platform/issues/34342

This dependency looks like a bit of leftover code that was overlooked
during the removal process.

This also upgrades other packages via "make upgrade".

@ormsbee ormsbee requested review from feanil and bmtcril April 23, 2025 15:53
@feanil
Copy link
Contributor

feanil commented Apr 23, 2025

@ormsbee looks like there are issues with the make upgrade I'll take a look at that, but for now, you could remove py2neo and then just run make compile-requirements to not pull in the other upgrades on this PR.

@ormsbee
chore: remove py2neo as a dependency
0f44a6b 
The py2neo package exists to support CourseGraph, which required the
Neo4j database. Support for it was removed before the Sumac cut, tracked
by the following DEPR:
  openedx#34342

It looks like the actual dependency install was just overlooked during
the removal process.
@ormsbee
Copy link
Contributor Author

ormsbee commented Apr 23, 2025

@feanil: Thanks. That looks much cleaner anyhow.

bmtcril
bmtcril approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@ormsbee ormsbee merged commit 77fda46 into openedx:master Apr 23, 2025
49 checks passed
@ormsbee ormsbee deleted the remove-neo4j branch April 23, 2025 22:18
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

@bmtcril bmtcril bmtcril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ormsbee @feanil @edx-pipeline-bot @bmtcril