Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Add Alerting Kibana IT for x64 with no security #648

Merged
merged 12 commits into from
Feb 19, 2021
Merged

Add Alerting Kibana IT for x64 with no security #648

merged 12 commits into from
Feb 19, 2021

Conversation

gaiksaya
Copy link
Member

@gaiksaya gaiksaya commented Feb 19, 2021

Issue #, if available:
#600

Description of changes:

  • Adding integration test in distribution workflow for alerting kibana
  • Since cypress is unavailable for ARM64, adding only to X64 workflows. Also integration test with security has some issue and has been informed to the team
  • Minor edits to keep consistency in workflow (eg: Update ubuntu-16.04 to ubuntu 18.04)

Test Results:

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Copy link
Contributor

@peterzhuamazon peterzhuamazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are only x64 tests, where are the ARM64 test?
If you plan to send it in another PR please rename the PR name to reflect this.
Thanks.

@gaiksaya
Copy link
Member Author

These are only x64 tests, where are the ARM64 test?
If you plan to send it in another PR please rename the PR name to reflect this.
Thanks.

No cypress present for ARM64. I have mentioned in the PR description.

@peterzhuamazon
Copy link
Contributor

These are only x64 tests, where are the ARM64 test?
If you plan to send it in another PR please rename the PR name to reflect this.
Thanks.

No cypress present for ARM64. I have mentioned in the PR description.

I see. Thanks.

@sreekarjami sreekarjami changed the title Add Alerting Kibana IT with no security Add Alerting Kibana IT for x64 with no security Feb 19, 2021
@gaiksaya gaiksaya merged commit d0a38ce into main Feb 19, 2021
@gaiksaya gaiksaya deleted the alerting-kib branch February 19, 2021 20:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants