Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Hook up integration test for Alerting Kibana plugin #600

Closed
tlfeng opened this issue Feb 6, 2021 · 9 comments · Fixed by #698
Closed

Hook up integration test for Alerting Kibana plugin #600

tlfeng opened this issue Feb 6, 2021 · 9 comments · Fixed by #698
Labels
infra Infra Team Issues security disabled This Plugin Disables The Security Features security enabled This Plugin Enables The Security Features testing

Comments

@tlfeng
Copy link

tlfeng commented Feb 6, 2021

Request adding integration test for Alerting Kibana plugin to the build workflow with and without security

Assumption:
With security: Elasticsearch is running at http://localhost:9200, Kibana is running at http://localhost:5601
Without security: Elasticsearch is running at https://localhost:9200, Kibana is running at http://localhost:5601

Step to run the test:

  1. Start Elasticsearch server with Alerting plugin
  2. Start Kibana server with Alerting Kibana plugin
  3. (Wait for enough time to make sure Kibana server fully started)
  4. In the plugin directory (kibana/plugins/alerting-kibana-plugin), run command in below to start the Cypress test

With security: yarn run cypress run --env security_enabled=true
WIthout security: yarn run cypress run

A successful workflow run in Alerting Kibana plugin repo, without security enabled:
https://github.com/opendistro-for-elasticsearch/alerting-kibana-plugin/actions/runs/489045146
(A test failure is expected when running against Alerting Kibana plugin v1.12.0.2)
The PR to support running Cypress test in ODFE cluster with security enabled for Alerting Kibana plugin:
opendistro-for-elasticsearch/alerting-kibana-plugin#235

@tlfeng tlfeng added enhancement New feature or request infra Infra Team Issues security disabled This Plugin Disables The Security Features security enabled This Plugin Enables The Security Features testing and removed enhancement New feature or request labels Feb 6, 2021
@gaiksaya
Copy link
Member

gaiksaya commented Feb 19, 2021

Hi @tlfeng,

I am working on this issue. However while doing so looks like the the non security tests are working well but for security test it is failing. I am testing with 1.13.0.
Please find the below test runs for alerting kibana plugin with security:
https://github.com/opendistro-for-elasticsearch/opendistro-build/runs/1931065268?check_suite_focus=true
https://github.com/opendistro-for-elasticsearch/opendistro-build/runs/1931401599?check_suite_focus=true

Please let us know if you have any update to resolve it. Till then I'll work on adding non-security tests.
Thanks!

@tlfeng
Copy link
Author

tlfeng commented Feb 19, 2021

Thank you for informing me the result of the workflow runs. Let me take a loot at the failures.

@tlfeng
Copy link
Author

tlfeng commented Feb 23, 2021

Seems the test failure is caused by this modal appears on the top, I'm going to find solution for it.
select your tenant - modal 7 10 2

@gaiksaya
Copy link
Member

Sure @tlfeng . Let me know when you fix it or have an update.
Thanks!

@bbarani
Copy link

bbarani commented Mar 10, 2021

@tlfeng , Any update on this issue?

@tlfeng
Copy link
Author

tlfeng commented Mar 11, 2021

Hi @bbarani, sorry that I haven't took much time on finding the solution. I will try to find the fix in this week, including checking how other plugins deal with it.

@tlfeng
Copy link
Author

tlfeng commented Mar 15, 2021

Hi @gaiksaya,
Sorry for the delay.
The fix of the test failure in ODFE 1.13 was merged, and please help me verify the test result when you have time.
Thank you!

@gaiksaya
Copy link
Member

Hi @tlfeng ,

Thank you for fixing it. I have created the PR to add the tests in our workflows.

@gaiksaya gaiksaya linked a pull request Mar 16, 2021 that will close this issue
@tlfeng
Copy link
Author

tlfeng commented Mar 16, 2021

Thank you for your rapid action! 👍👍 @gaiksaya

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
infra Infra Team Issues security disabled This Plugin Disables The Security Features security enabled This Plugin Enables The Security Features testing
Projects
None yet
3 participants