This repository was archived by the owner on Aug 2, 2022. It is now read-only.
Fix e2e test failure when by setting security tenant when visiting Kibana #245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
opendistro-for-elasticsearch/opendistro-build#600
The E2E test fails due to the "select your tenant" modal shows up when a user visits Kibana for the first time, and probably because of a change in security plugin in ODFE 1.13.

The modal will disappear if user click any button ("close", "cancel", or "confirm"), or refresh the page.
Description of changes:
security_tenant='private'
in the URL parameter of the HTTP request for visiting Kibana.The the full request will be like:
http://localhost:5601/app/home?security_tenant='private'
Explanation:
From the code in " opendistro-for-elasticsearch/security-kibana-plugin" repository, The
security_tenant
can be either put in the HTTP request header or the URL parameter.I chose to put into the URL query parameter, because it didn't work for me to put into the header through Cypress.
According to the document, all users at least have access to 2 tenants: "Private" and "Global". "Private" is the default for "Security Kibana Plugin", so I set it in the test.
Testing:
Started an ODFE cluster through Docker image, and ran
yarn run cypress run --env security_enabled=ture
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.