Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Fix e2e test failure when by setting security tenant when visiting Kibana #245

Merged
merged 1 commit into from
Mar 15, 2021
Merged

Fix e2e test failure when by setting security tenant when visiting Kibana #245

merged 1 commit into from
Mar 15, 2021

Conversation

tlfeng
Copy link
Contributor

@tlfeng tlfeng commented Mar 14, 2021

Issue #, if available:
opendistro-for-elasticsearch/opendistro-build#600

The E2E test fails due to the "select your tenant" modal shows up when a user visits Kibana for the first time, and probably because of a change in security plugin in ODFE 1.13.
select your tenant - modal 7 10 2

The modal will disappear if user click any button ("close", "cancel", or "confirm"), or refresh the page.

Description of changes:

  • Add security_tenant='private' in the URL parameter of the HTTP request for visiting Kibana.
    The the full request will be like: http://localhost:5601/app/home?security_tenant='private'

Explanation:
From the code in " opendistro-for-elasticsearch/security-kibana-plugin" repository, The security_tenant can be either put in the HTTP request header or the URL parameter.

I chose to put into the URL query parameter, because it didn't work for me to put into the header through Cypress.

According to the document, all users at least have access to 2 tenants: "Private" and "Global". "Private" is the default for "Security Kibana Plugin", so I set it in the test.

Testing:
Started an ODFE cluster through Docker image, and ran yarn run cypress run --env security_enabled=ture

       Spec                                              Tests  Passing  Failing  Pending  Skipped  
  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ ✔  alert_spec.js                            02:23        5        5        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  destination_spec.js                      00:23        4        4        -        -        - │
  ├────────────────────────────────────────────────────────────────────────────────────────────────┤
  │ ✔  monitor_spec.js                          00:28        6        6        -        -        - │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘
    ✔  All specs passed!                        03:15       15       15        -        -        -  

✨  Done in 228.90s.

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

@tlfeng tlfeng added the testing adds or improves tests label Mar 14, 2021
@tlfeng tlfeng changed the title Fix e2e test failure when security enabled by setting tenant when visiting Kibana Fix e2e test failure when by setting security tenant when visiting Kibana Mar 14, 2021
@tlfeng
Copy link
Contributor Author

tlfeng commented Mar 14, 2021

@skkosuri-amzn Thank you for reviewing the PR so quickly. I realized that I requested the review too early, because I have wrote any description. 😄

@tlfeng tlfeng marked this pull request as ready for review March 14, 2021 07:11
@tlfeng tlfeng merged commit 0f52d13 into opendistro-for-elasticsearch:main Mar 15, 2021
@tlfeng tlfeng deleted the cypress-security-tenant branch March 30, 2021 04:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
testing adds or improves tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants