Skip to content

Use updated attributes with ATTR prefix in all packages #4896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #4572
JamieDanielson opened this issue Aug 1, 2024 · 4 comments
Closed
Tracked by #4572

Use updated attributes with ATTR prefix in all packages #4896

JamieDanielson opened this issue Aug 1, 2024 · 4 comments
Assignees
@trentm
Labels
never-stale

Comments

@JamieDanielson
Copy link
Member

JamieDanielson commented Aug 1, 2024 •
edited
Loading

This is part of Semantic Convention Update: Tracking Issue #4572.

This issue is for changing SEMRESATTRS_ and SEMATTRS_ prefixes to just ATTR_ for attributes. No new attributes should be added in this change.

Note: Import @opentelemetry/semantic-conventions for stable semantic conventions. Use a local semconv.ts file for unstable semantic conventions. There is a script in js-contrib to generate the local file.
@JamieDanielson JamieDanielson mentioned this issue Aug 1, 2024
Open
13 tasks
@JamieDanielson JamieDanielson added the blocked Currently blocked on another item label Aug 1, 2024
@JamieDanielson JamieDanielson mentioned this issue Aug 7, 2024
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Nov 18, 2024
@trentm trentm added never-stale and removed stale labels Nov 20, 2024
@trentm
Copy link
Contributor

trentm commented Nov 20, 2024

We need to sort out #5182 to know what to do for unstable semconv values used in core packages.

trentm added a commit to trentm/opentelemetry-js that referenced this issue Nov 20, 2024
@trentm
chore(resources): update semconv usage to modern ATTR_ export names
ddae409 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue Nov 20, 2024
Draft
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 8, 2025
@trentm
docs: update old/deprecated 'SemanticAttributes' usage
cfefab3 
This also updates these doc examples to closer to modern/stable
HTTP and DB semantics. They are just examples though so I wasn't
extremely careful.

Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 8, 2025
Merged
@trentm trentm self-assigned this May 8, 2025
@trentm trentm removed the blocked Currently blocked on another item label May 8, 2025
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(resources): update semconv usage to ATTR_ exports
6802dcb 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(sdk-node): update semconv usage to ATTR_ exports
d8dc1fe 
This also removes a number of exports from
test/util/resource-assertions.ts that were unused.

Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(sdk-trace-base): update semconv usage to ATTR_ exports
e15c30c 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(sdk-trace-node): update semconv usage to ATTR_ exports
ccb5e56 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(sdk-trace-web): update semconv usage to ATTR_ exports
1b39b69 
This also moves the semantic-conventions dep to a devDep, because
it is no longer used in the runtime code.

Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(exporter-zipkin): update semconv usage to ATTR_ exports
0302ca7 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(shim-opentracing): update semconv usage to ATTR_ exports
342e569 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(exporter-prometheus): update semconv usage to ATTR_ exports
b359077 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
trentm added a commit to trentm/opentelemetry-js that referenced this issue May 9, 2025
@trentm
refactor(exporter-jaeger): update semconv usage to ATTR_ exports
fdecb43 
Refs: open-telemetry#4896
@trentm trentm mentioned this issue May 9, 2025
Merged
@trentm
Copy link
Contributor

trentm commented May 9, 2025

^^^ The PRs above handle updating all usage of the old deprecated semconv package exports (along with #5662).

@trentm
Copy link
Contributor

trentm commented May 9, 2025

Once #5662 goes in, I believe this is done.

@trentm trentm closed this as completed May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trentm trentm

Labels
never-stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trentm @JamieDanielson