-
Notifications
You must be signed in to change notification settings - Fork 574
Use updated semantic-conventions pkg exports with ATTR_
prefix in all packages
#2377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Need to sort out open-telemetry/opentelemetry-js#5182 first (how to handle unstable semconv attributes). |
The set to work through:
Plus this old practice in instr-undici:
Plus some hits like these:
|
ATTR_
prefix in all packages
plugins/node/instrumentation-amqplibCannot update because it uses old exports (a) that don't have ATTR_ equivalents (e.g. SEMATTRS_MESSAGING_DESTINATION moved to ATTR_MESSAGING_DESTINATION_NAME, diff value) or (b) subtley changed value (SEMATTRS_MESSAGING_MESSAGE_ID messaging.message_id -> ATTR_MESSAGING_MESSAGE_ID messaging.message.id).
|
Similar to open-telemetry/opentelemetry-js#4896 in core, but in contrib
This is part of Semantic Convention Update: Tracking Issue #4572.
This issue is for changing
SEMRESATTRS_
andSEMATTRS_
prefixes to justATTR_
for attributes. No new attributes should be added in this change.Note: Import
@opentelemetry/semantic-conventions
for stable semantic conventions. Use a localsemconv.ts
file for unstable semantic conventions. There is a script in js-contrib to generate the local file.The text was updated successfully, but these errors were encountered: