Make the MinMaxSumCount aggregations be true delta aggregations #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
requested review from
arminru,
bogdandrutu,
carlosalberto,
pavolloffay,
songy23 and
tylerbenson
as code owners
|
@jkwatson any plan to continue on this or drop? |
|
Let's close this for now. We can rework this when @jmacd 's work on clarifying how all this should happen is done. |
|
It's a two-part change at this point: |
|
FWIW, open-telemetry/opentelemetry-go#840 is the progress I was speaking of. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-on from #1032 to make the MinMaxSumCount aggregations actually create deltas properly, with the timestamps set appropriately.
It also demonstrates the beginnings of how we might make the aggregations be able to behave in a delta or a cumulative mode.