-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add export timestamps; distinguish Accumulation vs. Record #835
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
For the record, the replacement branch for #799 contains the changes here plus the rest of #799: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial review, but I wanted to get some comments in now.
I think the overall strategy, but the Aggregator
interface embedding the Aggregation
interface seems troublesome. Otherwise, it looks good save for some variable renames (which I did not thoroughly exhaust).
(Thanks @MrAlias!) Co-authored-by: Tyler Yahn <[email protected]>
@MrAlias before you look again, I will check over the variable names of Accumulation variables that might be named like Records. |
(I've audited all uses of "Accumulation" for variable name and comment correctness.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
This PR is factored out of a successor to #799.
In the export API:
In the simple Integrator:
In the OTLP code path: