-
Notifications
You must be signed in to change notification settings - Fork 2.9k
[chore] Makefile: add gencodeowners #40073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT.
songy23
approved these changes
May 14, 2025
dehaansa
approved these changes
May 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useful improvement, thanks!
seongpil0948
pushed a commit
to seongpil0948/opentelemetry-collector-contrib
that referenced
this pull request
May 16, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40072 <!--Describe what testing was performed and which tests were added.--> #### Testing Added myself to a random receiver as a code owner and ran `make gencodeowners`. It generated the `CODEOWNERS` file correctly without requiring me to have a GitHub PAT (I do not have one set up). <!--Describe the documentation added.--> #### Documentation Added reference in `CONTRIBUTING.md` and in the `check-codeowners` GitHub Action error message. <!--Please delete paragraphs that you did not use before submitting.-->
johnleslie
pushed a commit
to johnleslie/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40072 <!--Describe what testing was performed and which tests were added.--> #### Testing Added myself to a random receiver as a code owner and ran `make gencodeowners`. It generated the `CODEOWNERS` file correctly without requiring me to have a GitHub PAT (I do not have one set up). <!--Describe the documentation added.--> #### Documentation Added reference in `CONTRIBUTING.md` and in the `check-codeowners` GitHub Action error message. <!--Please delete paragraphs that you did not use before submitting.-->
johnleslie
pushed a commit
to johnleslie/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40072 <!--Describe what testing was performed and which tests were added.--> #### Testing Added myself to a random receiver as a code owner and ran `make gencodeowners`. It generated the `CODEOWNERS` file correctly without requiring me to have a GitHub PAT (I do not have one set up). <!--Describe the documentation added.--> #### Documentation Added reference in `CONTRIBUTING.md` and in the `check-codeowners` GitHub Action error message. <!--Please delete paragraphs that you did not use before submitting.-->
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40072 <!--Describe what testing was performed and which tests were added.--> #### Testing Added myself to a random receiver as a code owner and ran `make gencodeowners`. It generated the `CODEOWNERS` file correctly without requiring me to have a GitHub PAT (I do not have one set up). <!--Describe the documentation added.--> #### Documentation Added reference in `CONTRIBUTING.md` and in the `check-codeowners` GitHub Action error message. <!--Please delete paragraphs that you did not use before submitting.-->
dd-jasminesun
pushed a commit
to DataDog/opentelemetry-collector-contrib
that referenced
this pull request
Jun 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#40072 <!--Describe what testing was performed and which tests were added.--> #### Testing Added myself to a random receiver as a code owner and ran `make gencodeowners`. It generated the `CODEOWNERS` file correctly without requiring me to have a GitHub PAT (I do not have one set up). <!--Describe the documentation added.--> #### Documentation Added reference in `CONTRIBUTING.md` and in the `check-codeowners` GitHub Action error message. <!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT.
Link to tracking issue
Fixes #40072
Testing
Added myself to a random receiver as a code owner and ran
make gencodeowners
. It generated theCODEOWNERS
file correctly without requiring me to have a GitHub PAT (I do not have one set up).Documentation
Added reference in
CONTRIBUTING.md
and in thecheck-codeowners
GitHub Action error message.