Skip to content

[chore] Makefile: add gencodeowners #40073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025

Conversation

braydonk
Copy link
Contributor

Description

This PR adds a target to the Makefile to generate the CODEOWNERS file locally without a GitHub PAT.

Link to tracking issue

Fixes #40072

Testing

Added myself to a random receiver as a code owner and ran make gencodeowners. It generated the CODEOWNERS file correctly without requiring me to have a GitHub PAT (I do not have one set up).

Documentation

Added reference in CONTRIBUTING.md and in the check-codeowners GitHub Action error message.

This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.
@braydonk braydonk requested a review from a team as a code owner May 14, 2025 13:46
@braydonk braydonk requested a review from dmitryax May 14, 2025 13:46
Copy link
Contributor

@dehaansa dehaansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful improvement, thanks!

@songy23 songy23 merged commit 84f1030 into open-telemetry:main May 14, 2025
173 checks passed
@github-actions github-actions bot added this to the next release milestone May 14, 2025
seongpil0948 pushed a commit to seongpil0948/opentelemetry-collector-contrib that referenced this pull request May 16, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40072

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added myself to a random receiver as a code owner and ran `make
gencodeowners`. It generated the `CODEOWNERS` file correctly without
requiring me to have a GitHub PAT (I do not have one set up).

<!--Describe the documentation added.-->
#### Documentation
Added reference in `CONTRIBUTING.md` and in the `check-codeowners`
GitHub Action error message.

<!--Please delete paragraphs that you did not use before submitting.-->
johnleslie pushed a commit to johnleslie/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40072

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added myself to a random receiver as a code owner and ran `make
gencodeowners`. It generated the `CODEOWNERS` file correctly without
requiring me to have a GitHub PAT (I do not have one set up).

<!--Describe the documentation added.-->
#### Documentation
Added reference in `CONTRIBUTING.md` and in the `check-codeowners`
GitHub Action error message.

<!--Please delete paragraphs that you did not use before submitting.-->
johnleslie pushed a commit to johnleslie/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40072

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added myself to a random receiver as a code owner and ran `make
gencodeowners`. It generated the `CODEOWNERS` file correctly without
requiring me to have a GitHub PAT (I do not have one set up).

<!--Describe the documentation added.-->
#### Documentation
Added reference in `CONTRIBUTING.md` and in the `check-codeowners`
GitHub Action error message.

<!--Please delete paragraphs that you did not use before submitting.-->
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40072

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added myself to a random receiver as a code owner and ran `make
gencodeowners`. It generated the `CODEOWNERS` file correctly without
requiring me to have a GitHub PAT (I do not have one set up).

<!--Describe the documentation added.-->
#### Documentation
Added reference in `CONTRIBUTING.md` and in the `check-codeowners`
GitHub Action error message.

<!--Please delete paragraphs that you did not use before submitting.-->
dd-jasminesun pushed a commit to DataDog/opentelemetry-collector-contrib that referenced this pull request Jun 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR adds a target to the Makefile to generate the CODEOWNERS file
locally without a GitHub PAT.

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#40072

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Added myself to a random receiver as a code owner and ran `make
gencodeowners`. It generated the `CODEOWNERS` file correctly without
requiring me to have a GitHub PAT (I do not have one set up).

<!--Describe the documentation added.-->
#### Documentation
Added reference in `CONTRIBUTING.md` and in the `check-codeowners`
GitHub Action error message.

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to makefile for generating codeowners file without GitHub token
3 participants