Skip to content

[processor/tailsampling] Deprecate invert sample decisions #39833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

portertech
Copy link
Contributor

Description

Users can now use the newly added Drop policy type to explicitly drop (not sample) specific traces regardless of other policy decisions. This pull-request deprecates the invert sample decisions.

This pull-request introduces a feature gate/flag, processor.tailsamplingprocessor.disableinvertsample, to disable the invert sample decisions. The gate/flag influences the underlying policy evaluation for simplicity. With the gate/flag enabled, the string, numeric, and boolean filter policies still support invert_match, which continues to flip the decision for the individual policy (only Sampled and NotSampled). Letting invert_match be simple.

Related Issues

TODO

  • Log deprecation warning
  • Document the deprecation
  • Document the feature gate/flag

@github-actions github-actions bot added the processor/tailsampling Tail sampling processor label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
processor/tailsampling Tail sampling processor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant