[processor/tailsampling] Drop policy type #39668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request introduces a new policy type to explicitly drop traces regardless of other policy decisions. The new
drop
policy type behaves much like anand
, however, it returns aDropped
decision when all of its policies returnSampled
. ADropped
decision takes precedence over all others. TheDropped
decision is not new, however, it was unused and therefor safe to use for this purpose. This new policy type is very approachable and capable.This new policy type can be used to replace the top-level (not within an
and
policy) use ofinvert_match
to control the final sampling decision. We could deprecate the currentinvert_match
top-level decision logic. The string, numeric, and boolean filter policies still supportinvert_match
, which continues to flip the decision for the individual policy. Letinvert_match
be simple.Example:
This is a reduced version of a previous PR #37760
Related Issues