[confmap/provider/s3provider] Remove duplicate check for scheme #38664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjlshen
force-pushed
the
s3-confmap-regex
branch
from
480edea to
f361454
Compare
mjlshen
changed the title
atoulme
added
Skip Changelog
|
@Aneurysm9 please review as codeowner. |
This was referenced Mar 23, 2025
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
mjlshen
force-pushed
the
s3-confmap-regex
branch
from
f361454 to
f2687b4
Compare
|
Rebased the PR in an attempt to remove the |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This was already being checked by the S3 URI regular expression Signed-off-by: Michael Shen <[email protected]>
mjlshen
force-pushed
the
s3-confmap-regex
branch
from
f2687b4 to
905d4c1
Compare
atoulme
approved these changes
Apr 19, 2025
akshays-19
pushed a commit
to akshays-19/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2025
…-telemetry#38664) #### Description This was already being checked by the S3 URI regular expression evaluation/parsing. #### Testing I refactored the previously existing `Unsupported scheme` unit test into `TestURIs` Signed-off-by: Michael Shen <[email protected]>
Fiery-Fenix
pushed a commit
to Fiery-Fenix/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2025
…-telemetry#38664) #### Description This was already being checked by the S3 URI regular expression evaluation/parsing. #### Testing I refactored the previously existing `Unsupported scheme` unit test into `TestURIs` Signed-off-by: Michael Shen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This was already being checked by the S3 URI regular expression evaluation/parsing.
Testing
I refactored the previously existing
Unsupported schemeunit test intoTestURIs