Remove duplicate check for scheme

This was already being checked by the S3 URI regular expression

Signed-off-by: Michael Shen <[email protected]>

Author: mjlshen

confmap/provider/s3provider/provider.go

@@ -56,10 +56,6 @@ func newWithSettings(_ confmap.ProviderSettings) confmap.Provider {
 }
 
 func (fmp *provider) Retrieve(ctx context.Context, uri string, _ confmap.WatcherFunc) (*confmap.Retrieved, error) {
-	if !strings.HasPrefix(uri, schemeName+":") {
-		return nil, fmt.Errorf("%q uri is not supported by %q provider", uri, schemeName)
-	}
-
 	// initialize the s3 client in the first call of Retrieve
 	if fmp.client == nil {
 		cfg, err := config.LoadDefaultConfig(context.Background())

confmap/provider/s3provider/provider_test.go

@@ -77,6 +77,7 @@ func TestURIs(t *testing.T) {
 		{"No bucket", "s3://s3.region.amazonaws.com/key", "", "", "", false},
 		{"No region", "s3://some-bucket.s3..amazonaws.com/key", "", "", "", false},
 		{"Test malformed uri", "s3://some-bucket.s3.us-west-2.amazonaws.com/key%", "", "", "", false},
+		{"Unsupported scheme", "https://google.com", "", "", "", false},
 		{"Valid bucket", "s3://bucket.name-here.s3.us-west-2.amazonaws.com/key", "bucket.name-here", "us-west-2", "key", true},
 	}
 
@@ -94,13 +95,6 @@ func TestURIs(t *testing.T) {
 	}
 }
 
-func TestUnsupportedScheme(t *testing.T) {
-	fp := newTestProvider("./testdata/otel-config.yaml")
-	_, err := fp.Retrieve(context.Background(), "https://google.com", nil)
-	assert.Error(t, err)
-	assert.NoError(t, fp.Shutdown(context.Background()))
-}
-
 func TestNonExistent(t *testing.T) {
 	fp := newTestProvider("./testdata/non-existent.yaml")
 	_, err := fp.Retrieve(context.Background(), "s3://non-exist-bucket.s3.region.amazonaws.com/key", nil)