Skip to content

[receiver/vcenter] Adds vSAN metrics for Clusters #34084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StefanKurek
Copy link
Contributor

@StefanKurek StefanKurek commented Jul 15, 2024

Description:
Waiting on #34082 to be merged first.
Adds a set of default disabled vSAN metrics for Clusters.

vcenter.cluster.vsan.throughput          (direction={read/write})
vcenter.cluster.vsan.iops                (direction={read/write})
vcenter.cluster.vsan.latency.avg         (direction={read/write})
vcenter.cluster.vsan.congestions

Link to tracking Issue:
#33556

Testing:
Unit tests added for scraper.
Could not add client tests as govmomi vSAN simulator currently not implemented.
Test against live environment.

Documentation:
New documentation generated

@github-actions github-actions bot requested review from djaglowski and schmikei July 15, 2024 22:01
@StefanKurek StefanKurek force-pushed the feat/add-vsan-cluster-metrics branch from b07a4f7 to f6b3db2 Compare July 24, 2024 20:53
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jul 24, 2024
@StefanKurek StefanKurek marked this pull request as ready for review July 24, 2024 20:54
@StefanKurek StefanKurek requested a review from a team July 24, 2024 20:54
@StefanKurek StefanKurek force-pushed the feat/add-vsan-cluster-metrics branch 4 times, most recently from d6c943c to bb8da51 Compare July 26, 2024 14:18
@StefanKurek StefanKurek force-pushed the feat/add-vsan-cluster-metrics branch from bb8da51 to e76518d Compare July 26, 2024 16:19
@djaglowski djaglowski merged commit 2ae66fe into open-telemetry:main Jul 29, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 29, 2024
@StefanKurek StefanKurek deleted the feat/add-vsan-cluster-metrics branch July 29, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants