[receiver/vcenter] Adds vSAN metrics for Virtual Machines #34082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
feat/add-vsan-vm-metrics
branch
from
4787d41 to
b98ed88
Compare
StefanKurek
force-pushed
the
feat/add-vsan-vm-metrics
branch
from
50fc67d to
4e23dd0
Compare
StefanKurek
force-pushed
the
feat/add-vsan-vm-metrics
branch
from
4e23dd0 to
1b09863
Compare
StefanKurek
force-pushed
the
feat/add-vsan-vm-metrics
branch
from
1b09863 to
55b0e23
Compare
djaglowski
reviewed
Jul 25, 2024
| @@ -26,6 +26,7 @@ dist/ | |||
| # Miscellaneous files | |||
| *.sw[op] | |||
| *.DS_Store | |||
| __debug_bin* | |||
There was a problem hiding this comment.
Suggested change
| __debug_bin* |
There was a problem hiding this comment.
@djaglowski These were building up in my directory as I've been debugging and showing up as files that could be committed. Any reason not to ignore them?
StefanKurek
force-pushed
the
feat/add-vsan-vm-metrics
branch
from
22caa6c to
c1bb206
Compare
djaglowski
approved these changes
Jul 26, 2024
djaglowski
pushed a commit
that referenced
this pull request
Jul 29, 2024
**Description:** <Describe what has changed.> Waiting on #34082 to be merged first. Adds a set of default disabled vSAN metrics for Clusters. ``` vcenter.cluster.vsan.throughput (direction={read/write}) vcenter.cluster.vsan.iops (direction={read/write}) vcenter.cluster.vsan.latency.avg (direction={read/write}) vcenter.cluster.vsan.congestions ``` **Link to tracking Issue:** <Issue number if applicable> #33556 **Testing:** <Describe what testing was performed and which tests were added.> Unit tests added for scraper. Could not add client tests as govmomi vSAN simulator currently not implemented. Test against live environment. **Documentation:** <Describe the documentation added.> New documentation generated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a set of vSAN metrics for Virtual Machines.
Link to tracking Issue:
#33556
Testing:
Unit tests added for scraper.
Could not add client tests as
govmomivSAN simulator currently not implemented.Tested against live environment.
Documentation:
New documentation generated