Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change attribute names in ActivityTracer.java and FragmentTracer.java #920

Merged
merged 3 commits into from
Apr 4, 2025
Merged

Change attribute names in ActivityTracer.java and FragmentTracer.java #920

merged 3 commits into from
Apr 4, 2025

Conversation

bendeguzvarju
Copy link
Contributor

Change attribute names in ActivityTracer.java and FragmentTracer.java

Issue: #865

@bendeguzvarju bendeguzvarju requested a review from a team as a code owner April 2, 2025 16:33
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 2, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@breedx-splk
Copy link
Contributor

Awesome, thanks! Would you mind opening a CHANGELOG entry? Thanks.

@bendeguzvarju
Copy link
Contributor Author

Not sure if this is the right way to link lines of code, but I'll give it a try:

Am I right to assume that the attributes in the READMEs at
instrumentation/activity/README.md:37 and instrumentation/fragment/README.md:22 have to be updated to activity.name and fragment.name in order to keep up to date with this change?

@breedx-splk breedx-splk merged commit 1621d08 into open-telemetry:main Apr 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breedx-splk breedx-splk breedx-splk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendeguzvarju @breedx-splk