Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attribute keys' names in camel case, not dot separated #865

Open
magda-woj opened this issue Mar 3, 2025 · 1 comment
Open

Attribute keys' names in camel case, not dot separated #865

magda-woj opened this issue Mar 3, 2025 · 1 comment
Assignees
@bendeguzvarju
Labels
contribfest Kubecon contribfest candidate

Comments

@magda-woj
Copy link
Contributor

The attribute keys' names activityName and fragmentName defined in ActivityTracer.java and FragmentTracer.java respectively are camel case, not dot separated. It's inconsistent with other attribute keys' names of the same spans (e.g. screen.name), counterparts in other spans (slow rendering spans have an attribute with key activity.name) and general otel conventions.
@magda-woj magda-woj mentioned this issue Mar 3, 2025
Merged
@breedx-splk breedx-splk added the contribfest Kubecon contribfest candidate label Apr 1, 2025
@bendeguzvarju
Copy link
Contributor

I'd like to take this.

@bendeguzvarju bendeguzvarju mentioned this issue Apr 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bendeguzvarju bendeguzvarju

Labels
contribfest Kubecon contribfest candidate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bendeguzvarju @breedx-splk @magda-woj