Fix usage of deprecated webhook.Validator interface #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dale Haiducek <[email protected]>
Replace usage of deprecated `webhook.Validator` interface with `admission.CustomValidator`. Signed-off-by: Saeid Askari <[email protected]>
|
this unblock upgrading sigs.k8s.io/controller-runtime to v0.20.2 |
dhaiducek
previously approved these changes
Mar 7, 2025
|
/hold |
yiraeChristineKim
previously approved these changes
Mar 7, 2025
dhaiducek
approved these changes
Mar 8, 2025
dhaiducek
requested changes
Mar 8, 2025
sudomakeinstall2
force-pushed
the
main
branch
2 times, most recently
from
820cfa6 to
9609572
Compare
yiraeChristineKim
approved these changes
Mar 10, 2025
dhaiducek
approved these changes
Mar 10, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, sudomakeinstall2, yiraeChristineKim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold @dhaiducek No problem. Thank you for quick reviews. |
openshift-merge-bot
bot
merged commit a2769fe
into
open-cluster-management-io:main
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usage of deprecated
webhook.Validatorinterface withadmission.CustomValidator.