Fix usage of deprecated webhook.Validator interface

Replace usage of deprecated `webhook.Validator` interface with
`admission.CustomValidator`.

Signed-off-by: Saeid Askari <[email protected]>

Author: sudomakeinstall2

api/v1/policy_webhook.go

@@ -4,6 +4,7 @@
 package v1
 
 import (
+	"context"
 	"encoding/json"
 	"errors"
 	"fmt"
@@ -29,46 +30,60 @@ var (
 func (r *Policy) SetupWebhookWithManager(mgr ctrl.Manager) error {
 	return ctrl.NewWebhookManagedBy(mgr).
 		For(r).
+		WithValidator(&PolicyCustomValidator{}).
 		Complete()
 }
 
-//+kubebuilder:webhook:path=/validate-policy-open-cluster-management-io-v1-policy,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=policy.open-cluster-management.io,resources=policies,verbs=create,versions=v1,name=policy.open-cluster-management.io.webhook,admissionReviewVersions=v1
+type PolicyCustomValidator struct{}
 
-var _ webhook.Validator = &Policy{}
+// +kubebuilder:webhook:path=/validate-policy-open-cluster-management-io-v1-policy,mutating=false,failurePolicy=Ignore,sideEffects=None,groups=policy.open-cluster-management.io,resources=policies,verbs=create,versions=v1,name=policy.open-cluster-management.io.webhook,admissionReviewVersions=v1
+var _ webhook.CustomValidator = &PolicyCustomValidator{}
 
-// ValidateCreate implements webhook.Validator so a webhook will be registered for the type
-func (r *Policy) ValidateCreate() (admission.Warnings, error) {
-	log := policylog.WithValues("policyName", r.Name, "policyNamespace", r.Namespace)
+// ValidateCreate implements webhook.CustomValidator so a webhook will be registered for the type
+func (r *PolicyCustomValidator) ValidateCreate(_ context.Context, obj runtime.Object) (admission.Warnings, error) {
+	policy, ok := obj.(*Policy)
+	log := policylog.WithValues("policyName", policy.Name, "policyNamespace", policy.Namespace)
 	log.V(1).Info("Validate policy creation request")
 
-	err := r.validateName()
+	if !ok {
+		return nil, fmt.Errorf("expected a Policy object but got %T", obj)
+	}
+
+	err := policy.validateName()
 	if err != nil {
 		return nil, err
 	}
 
-	err = r.validateRemediationAction()
+	err = policy.validateRemediationAction()
 	if err != nil {
 		return nil, err
 	}
 
 	return nil, nil
 }
 
-// ValidateUpdate implements webhook.Validator so a webhook will be registered for the type
-func (r *Policy) ValidateUpdate(_ runtime.Object) (admission.Warnings, error) {
-	log := policylog.WithValues("policyName", r.Name, "policyNamespace", r.Namespace)
+// ValidateUpdate implements webhook.CustomValidator so a webhook will be registered for the type
+func (r *PolicyCustomValidator) ValidateUpdate(
+	_ context.Context, _, newObj runtime.Object,
+) (admission.Warnings, error) {
+	policy, ok := newObj.(*Policy)
+	log := policylog.WithValues("policyName", policy.Name, "policyNamespace", policy.Namespace)
 	log.V(1).Info("Validate policy update request")
 
-	err := r.validateRemediationAction()
+	if !ok {
+		return nil, fmt.Errorf("expected a Policy object but got %T", newObj)
+	}
+
+	err := policy.validateRemediationAction()
 	if err != nil {
 		return nil, err
 	}
 
 	return nil, nil
 }
 
-// ValidateDelete implements webhook.Validator so a webhook will be registered for the type
-func (r *Policy) ValidateDelete() (admission.Warnings, error) {
+// ValidateDelete implements webhook.CustomValidator so a webhook will be registered for the type
+func (r *PolicyCustomValidator) ValidateDelete(_ context.Context, _ runtime.Object) (admission.Warnings, error) {
 	return nil, nil
 }