More package upgrades #109
Conversation
go.mod
Outdated
| @@ -94,5 +94,6 @@ require ( | |||
| replace ( | |||
| golang.org/x/crypto => golang.org/x/crypto v0.0.0-20220321153916-2c7772ba3064 // CVE-2021-43565 | |||
| golang.org/x/text => golang.org/x/text v0.3.8 // CVE-2022-32149 | |||
| k8s.io/client-go => k8s.io/client-go v0.26.1 | |||
| k8s.io/api => k8s.io/api v0.26.4 | |||
There was a problem hiding this comment.
Why replace it here, as opposed to just using v0.26.4 in the top require section? My understanding was that we have client-go down here because we need to declare it as v12.0.0+incompatible for some other dependency...
There was a problem hiding this comment.
I suppose it'd work either way, but for some reason go get -u won't work unless this replace is here:
$ go get -u ./...
open-cluster-management.io/governance-policy-propagator imports
k8s.io/client-go/kubernetes/scheme imports
k8s.io/api/resource/v1alpha1: cannot find module providing package k8s.io/api/resource/v1alpha1
So I think having the replace here will create less work in the future running the upgrade command. I'll add a note if that makes sense to you.
There was a problem hiding this comment.
(The v1alpha1 resource API was bumped to v1alpha2 in v0.27.1.)
There was a problem hiding this comment.
I guess... if it works, it works 🤷
There was a problem hiding this comment.
Yeah--I'm starting to get a handle on Go packages, but it's definitely still largely a black box to me.
Signed-off-by: Dale Haiducek <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Re-running CI, but I created an issue for that flaky templates test: https://issues.redhat.com/browse/ACM-5349 |
Through my package upgrade work, I found that the K8s API package was actually blocking upgrade paths. Replacing it let more upgrades through.
Followup to:
go-template-utilsto v3.2.0 #106