Skip to content

Upgrade go-template-utils to v3.2.0 #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dhaiducek
Copy link
Member

gparvin
gparvin previously approved these changes Apr 19, 2023
@openshift-ci openshift-ci bot added the lgtm label Apr 19, 2023
@openshift-ci openshift-ci bot removed the lgtm label Apr 20, 2023
@dhaiducek dhaiducek force-pushed the update-tml-utils branch 2 times, most recently from 2ce72ab to 069df3c Compare May 4, 2023 00:55
@dhaiducek dhaiducek requested a review from gparvin May 4, 2023 01:01
JustinKuli
JustinKuli previously approved these changes May 4, 2023
@@ -80,7 +80,7 @@ linters-settings:
check-shadowing: false
gci:
sections:
- prefix(open-cluster-management.io/config-policy-controller)
- prefix(open-cluster-management.io/governance-policy-propagator)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😹

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah--makes me wonder whether this happens elsewhere! 😢

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably the config file I was thinking of... I need more coffee 😂

@dhaiducek
Copy link
Member Author

/hold @JustinKuli Thanks for the review--I'm going to update this PR to roll in the package upgrades also.

@dhaiducek dhaiducek force-pushed the update-tml-utils branch from c268650 to a5a9b34 Compare May 5, 2023 01:35
@dhaiducek
Copy link
Member Author

/unhold

@dhaiducek dhaiducek force-pushed the update-tml-utils branch from a5a9b34 to 1954d3e Compare May 5, 2023 01:39

# All available format: format-go format-protos format-python
# Default value will run all formats, override these make target with your requirements:
# eg: fmt: format-go format-protos
fmt: fmt-dependencies
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gofmt -s -w
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gci -w -local "$(shell cat go.mod | head -1 | cut -d " " -f 2)"
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gci write -s standard -s default -s "prefix($(shell cat go.mod | head -1 | cut -d " " -f 2))"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I remembered there being a spot for this in a config file? But maybe that can't do the (somewhat spiffy) reading of the go.mod.

@openshift-ci openshift-ci bot added the lgtm label May 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, JustinKuli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JustinKuli,dhaiducek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants