-
Notifications
You must be signed in to change notification settings - Fork 22
Upgrade go-template-utils
to v3.2.0
#106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade go-template-utils
to v3.2.0
#106
Conversation
2ce72ab
to
069df3c
Compare
@@ -80,7 +80,7 @@ linters-settings: | |||
check-shadowing: false | |||
gci: | |||
sections: | |||
- prefix(open-cluster-management.io/config-policy-controller) | |||
- prefix(open-cluster-management.io/governance-policy-propagator) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah--makes me wonder whether this happens elsewhere! 😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably the config file I was thinking of... I need more coffee 😂
/hold @JustinKuli Thanks for the review--I'm going to update this PR to roll in the package upgrades also. |
Signed-off-by: Dale Haiducek <[email protected]>
c268650
to
a5a9b34
Compare
/unhold |
ref: https://issues.redhat.com/browse/ACM-5042 ref: https://issues.redhat.com/browse/ACM-5032 Signed-off-by: Dale Haiducek <[email protected]>
a5a9b34
to
1954d3e
Compare
|
||
# All available format: format-go format-protos format-python | ||
# Default value will run all formats, override these make target with your requirements: | ||
# eg: fmt: format-go format-protos | ||
fmt: fmt-dependencies | ||
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gofmt -s -w | ||
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gci -w -local "$(shell cat go.mod | head -1 | cut -d " " -f 2)" | ||
find . -not \( -path "./.go" -prune \) -name "*.go" | xargs gci write -s standard -s default -s "prefix($(shell cat go.mod | head -1 | cut -d " " -f 2))" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought I remembered there being a spot for this in a config file? But maybe that can't do the (somewhat spiffy) reading of the go.mod
.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, JustinKuli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref: https://issues.redhat.com/browse/ACM-5032