-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Fix dynamic linking warning #8559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
johmani
wants to merge
129
commits into
ocornut:features/dynamic_fonts
from
johmani:features/dynamic_fonts
Closed
Fix dynamic linking warning #8559
johmani
wants to merge
129
commits into
ocornut:features/dynamic_fonts
from
johmani:features/dynamic_fonts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Transfer Buffers which were unusually slow to recreate every frame. (ocornut#8534)
Softly breaking. May require support from language binding generator. Rebased and reworked completely on 2025/03/19.
Which gives us room for potentially updating ImDrawData during render.
…hem on shutdown if atlas is shared.
…urn an accurate return value.
(To squash into "Added PushFontSize(), PopFontSize() api."
…ImTextureUserID_Invalid. .
Comments, tweaks
…n't update Status. + 1 fix
…(may backtrack and just keep old name)
…rroneously + failing to use ellipsis.
… sizing of merged fonts (8502)
Fixing typo. Broken by fe598f7
comments comments
+ internally add ImFontAtlasPackReuseRectEntry()
…cludes compacting texture data.
…out losing custom rects. Sharing more code.
Mark ImTextureData with IMGUI_API requiring ImVector to be exported as well; otherwise, MSVC outputs a warning on ImVector<ImTextureRect> updates.
a2ccc39
to
048cdb5
Compare
e4b08e8
to
b37a8c1
Compare
Thank you Mohamd. I had to manually recreate this as 6828437 as the PR somehow got broken (probably PR over branches I am force-pushing are currently tricky. Hopefully I'll stop force-pushing at some point). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark
ImTextureData with IMGUI_API
requiring ImVector to be exported as well; otherwise, MSVC outputs a warning onImVector<ImTextureRect>
updates.using Visual Studio 2022 (v143), c++20
warning C4251: 'ImTextureData::Updates': 'ImVector' needs to have dll-interface to be used by clients of 'ImTextureData'