Skip to content

Fix dynamic linking warning #8559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

johmani
Copy link

@johmani johmani commented Apr 8, 2025

Mark ImTextureData with IMGUI_API requiring ImVector to be exported as well; otherwise, MSVC outputs a warning on ImVector<ImTextureRect> updates.

using Visual Studio 2022 (v143), c++20
warning C4251: 'ImTextureData::Updates': 'ImVector' needs to have dll-interface to be used by clients of 'ImTextureData'

ocornut and others added 30 commits March 31, 2025 14:52
… Transfer Buffers which were unusually slow to recreate every frame. (ocornut#8534)
Softly breaking. May require support from language binding generator.
Rebased and reworked completely on 2025/03/19.
Which gives us room for potentially updating ImDrawData during render.
ocornut and others added 25 commits April 2, 2025 12:08
(To squash into "Added PushFontSize(), PopFontSize() api."
comments

comments
+ internally add ImFontAtlasPackReuseRectEntry()
Mark ImTextureData with IMGUI_API requiring ImVector to be exported as well; otherwise, MSVC outputs a warning on ImVector<ImTextureRect> updates.
@johmani johmani force-pushed the features/dynamic_fonts branch from a2ccc39 to 048cdb5 Compare April 8, 2025 21:41
@ocornut ocornut force-pushed the features/dynamic_fonts branch 2 times, most recently from e4b08e8 to b37a8c1 Compare April 9, 2025 13:11
@ocornut
Copy link
Owner

ocornut commented Apr 9, 2025

Thank you Mohamd. I had to manually recreate this as 6828437 as the PR somehow got broken (probably PR over branches I am force-pushing are currently tricky. Hopefully I'll stop force-pushing at some point).

@ocornut ocornut closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants