Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sqlite,src: refactor sqlite value conversion #57571

Merged
merged 3 commits into from
Apr 3, 2025
Merged

sqlite,src: refactor sqlite value conversion #57571

merged 3 commits into from
Apr 3, 2025

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Mar 21, 2025 •
edited
Loading

This PR is a minor refactor on converting SQLite values to JS. It makes the work for #56600 easier and reduces duplication.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Mar 21, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (1de917b) to head (94276bc).
Report is 74 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57571      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         629      630       +1     
  Lines      184903   185009     +106     
  Branches    36223    36221       -2     
==========================================
+ Hits       166853   166944      +91     
- Misses      11010    11038      +28     
+ Partials     7040     7027      -13
Files with missing lines Coverage Δ
src/node_sqlite.cc 78.20% <87.50%> (-0.29%) ⬇️

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 21, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65862/

@Renegade334
Copy link
Contributor

Is this "returning function body macro" paradigm used elsewhere? Appreciate the rationale, but it seems like it lends potential for future mishaps?

@geeksilva97
Copy link
Contributor Author

but it seems like it lends potential for future mishaps?

For this, specifically, I don't think so. This type conversion is unlikely to change. We need to find a way to isolate this anyways since it's being required more and more.

@geeksilva97 geeksilva97 mentioned this pull request Mar 22, 2025
Merged
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 22, 2025
cjihrig
cjihrig reviewed Mar 22, 2025
View reviewed changes
@geeksilva97 geeksilva97 force-pushed the sqlite-refactor-conversion-type branch from 6cf644e to 2611aa7 Compare March 24, 2025 20:44
@geeksilva97 geeksilva97 requested review from cjihrig and jasnell March 25, 2025 18:05
@geeksilva97 geeksilva97 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 25, 2025
cjihrig
cjihrig approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

@geeksilva97 geeksilva97 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 26, 2025
@geeksilva97 geeksilva97 self-assigned this Mar 26, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - sqlite,src: refactor sqlite value conversion
   ⚠  - fixup: apply review suggestions
   ⚠  - sqlite,src: improve conversion macro
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14195007818

@geeksilva97 geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 1, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 1, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025

Failed to start CI
   ⚠  Commits were pushed since the last approving review:
   ⚠  - sqlite,src: refactor sqlite value conversion
   ⚠  - fixup: apply review suggestions
   ⚠  - sqlite,src: improve conversion macro
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/14196415493

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Apr 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65962/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66000/

@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Apr 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 3, 2025
@nodejs-github-bot nodejs-github-bot merged commit 8360ce2 into nodejs:main Apr 3, 2025
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8360ce2

JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@geeksilva97 @JonasBa
sqlite,src: refactor sqlite value conversion
eaf7eba 
PR-URL: nodejs#57571
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig Awaiting requested review from anonrig

@RafaelGSS RafaelGSS Awaiting requested review from RafaelGSS

Assignees

@geeksilva97 geeksilva97

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@geeksilva97 @nodejs-github-bot @Renegade334 @jasnell @cjihrig @aduh95