sqlite: add aggregate function #56600
Merged
+843
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
targos
reviewed
Jan 20, 2025
jasnell
reviewed
Jan 20, 2025
cjihrig
reviewed
Jan 20, 2025
|
Also, tests and docs are needed. |
|
@geeksilva97 are you still planning to work on this? |
Hi @cjihrig . Yes, I plan to continue this. The last few weeks have been tough though. If nobody beats me I plan to get this done by April. |
geeksilva97
force-pushed
the
sqlite-aggregate-function
branch
7 times, most recently
from
beaf983 to
70dff34
Compare
geeksilva97
force-pushed
the
sqlite-aggregate-function
branch
from
70dff34 to
f4e4869
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56600 +/- ##
==========================================
- Coverage 90.24% 90.22% -0.02%
==========================================
Files 630 630
Lines 184990 185424 +434
Branches 36216 36347 +131
==========================================
+ Hits 166948 167307 +359
- Misses 11003 11016 +13
- Partials 7039 7101 +62
🚀 New features to boost your workflow:
|
|
I got an implementation that works. I need to add tests and clean up the code. |
geeksilva97
force-pushed
the
sqlite-aggregate-function
branch
3 times, most recently
from
cd3f0aa to
22da3ad
Compare
jasnell
reviewed
Mar 20, 2025
jasnell
reviewed
Mar 20, 2025
cjihrig
reviewed
Mar 20, 2025
geeksilva97
changed the title
geeksilva97
force-pushed
the
sqlite-aggregate-function
branch
from
22da3ad to
9badd9b
Compare
|
Failted test is unrelated to this PR. |
Co-authored-by: James M Snell <[email protected]>
geeksilva97
added
commit-queue
|
It needs re-approval because I accepted Jasmes' suggestions. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/56600 ✔ Done loading data for nodejs/node/pull/56600 ----------------------------------- PR info ------------------------------------ Title sqlite: add aggregate function (#56600) Author Edy Silva <[email protected]> (@geeksilva97) Branch geeksilva97:sqlite-aggregate-function -> nodejs:main Labels c++, author ready, needs-ci, commit-queue-squash, sqlite Commits 3 - sqlite,doc,test: add aggregate function - apply review suggestions - apply review suggestion Committers 2 - Edy Silva <[email protected]> - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/56600 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/56600 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - sqlite,doc,test: add aggregate function ⚠ - apply review suggestions ⚠ - apply review suggestion ℹ This PR was created on Tue, 14 Jan 2025 19:05:19 GMT ✔ Approvals: 2 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56600#pullrequestreview-2744917456 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/56600#pullrequestreview-2745190851 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-04-06T17:31:02Z: https://ci.nodejs.org/job/node-test-pull-request/66092/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - apply review suggestion - Querying data for job/node-test-pull-request/66092/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14310034479 |
cjihrig
reviewed
Apr 7, 2025
cjihrig
approved these changes
Apr 7, 2025
github-actions
bot
removed
the
request-ci
github-actions
bot
removed
the
request-ci
cjihrig
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 437c6aa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56511
inspired by https://github.com/WiseLibs/better-sqlite3/blob/master/docs/api.md#aggregatename-options---this