Skip to content

home-cursor: sway depend on cfg.size instead of gtk.cursorTheme.size #7176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025

Conversation

eyJhb
Copy link
Contributor

@eyJhb eyJhb commented May 31, 2025

Description

It seems like home.pointerCursor.sway.enable wrongly depends on gtk.cursorTheme.size. instead of just cfg.size. If we want to depend on gtk instead, then the name should also depend on gtk, at least from my logic.

It looks like it might have been an oversight from the initial PR here #6459

Maybe @ambroisie can clarify if this is intended? :)

Checklist

  • Change is backwards compatible.

  • Code formatted with nix fmt or
    nix-shell -p treefmt nixfmt-rfc-style keep-sorted --run treefmt.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@ambroisie
Copy link
Contributor

Yup, copy-paste error when using the hyprcursor one as a base.

Copy link
Contributor

@ambroisie ambroisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@khaneliman khaneliman merged commit 5675a96 into nix-community:master Jun 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants