Skip to content

home-cursor: add sway support #6459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

ambroisie
Copy link
Contributor

Description

Not sure if it should use * or seat0 for the configuration, as I'm not sure what the difference in semantics would be.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@Scrumplex @alexarice @sumnerevans @oxalica @league

@khaneliman
Copy link
Collaborator

khaneliman commented Feb 18, 2025

Not sure if it should use * or seat0 for the configuration, as I'm not sure what the difference in semantics would be.

From what I can read in their docs, it's the difference between applying to the first seat and all possible seats.

https://github.com/swaywm/sway/blob/f59b665792fb664d00c3acd91e30977a05dc09f3/sway/sway-input.5.scd#seat-configuration

@ambroisie
Copy link
Contributor Author

Well, yes. I guess I meant that I'm not sure which semantic is usually wanted: it's usually documented with seat0 (e.g: Arch Wiki) even though to me * seems more correct. If one wants to customize the cursor, don't they want it customized everywhere?

Copy link
Collaborator

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khaneliman khaneliman merged commit dde2fba into nix-community:master Feb 21, 2025
3 checks passed
347Online pushed a commit to 347Online/home-manager that referenced this pull request Mar 1, 2025
pasqui23 pushed a commit to pasqui23/home-manager that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants