Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{cliphist, wlsunset, swayr}: systemdTargets default to wayland.systemd target #6766

Merged
merged 4 commits into from
Apr 7, 2025

Conversation

khaneliman
Copy link
Collaborator

Description

Closes #6706

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all
    or nix build --reference-lock-file flake.lock ./tests#test-all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@khaneliman khaneliman merged commit c15ab0c into nix-community:master Apr 7, 2025
3 checks passed
@khaneliman khaneliman deleted the systemd branch April 7, 2025 04:06
@jmickelin
Copy link

Hi! Thank you so much for fixing this :)

One minor nitpick is that #6253 also says to also set the Unit configurations to include ConditionEnvironment = "WAYLAND_DISPLAY". This prevents the service from starting (and failing) under X, say if it's enabled on a system where you can choose between both X and Wayland sessions.

Any chance you could add this in a followup PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Use wayland.systemd.target for wlsunset
2 participants