Skip to content

bug: Use wayland.systemd.target for wlsunset #6706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
jmickelin opened this issue Mar 25, 2025 · 1 comment · Fixed by #6766
Closed
2 tasks done

bug: Use wayland.systemd.target for wlsunset #6706

jmickelin opened this issue Mar 25, 2025 · 1 comment · Fixed by #6766
Assignees
Labels
bug triage Issues or feature request that have not been triaged yet

Comments

@jmickelin
Copy link

jmickelin commented Mar 25, 2025

Are you following the right branch?

  • My Nixpkgs and Home Manager versions are in sync

Is there an existing issue for this?

  • I have searched the existing issues

Issue description

PR #6253 proposed a standardized format for Wayland-specific graphical systemd services, controlled by an option wayland.systemd.target.

It seems that services.wlsunset was missed, and it still uses a hard-coded value for After= and PartOf=, along with its own configuration option for WantedBy=. This should be fixed to adhere to the format and the option introduced in #6253, with the existing option defaulting to the value of wayland.systemd.target.

Of note: Another recent PR #5785 identifed and fixed a large number of services that incorrectly used graphical-session-pre.target, including wlsunset. It's possible that that PR includes additional Wayland services that were overlooked, so it's worth a look.

Maintainer CC

@matrss
@thiagokokada
@Scrumplex

System information

N/A
@jmickelin jmickelin added bug triage Issues or feature request that have not been triaged yet labels Mar 25, 2025
@jmickelin
Copy link
Author

A very non-exhaustive search (literally just for systemdTarget and systemd.target) found me two more Wayland-only services that use their own option, that should default to use the new wayland.systemd.target one:

  • services.cliphist
  • services.swayr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug triage Issues or feature request that have not been triaged yet
Projects
None yet
4 participants