Skip to content

fix: add code location and codeframe for rollup errors #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 31, 2022
Merged

fix: add code location and codeframe for rollup errors #406

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7560401
feat: add code location and codeframe for rollup errors
danielroe Aug 10, 2022
6af3bb0
Update src/build.ts
danielroe Aug 10, 2022
b4c588f
fix: handle plugin errors too
danielroe Aug 10, 2022
83f05ff
Merge remote-tracking branch 'origin/main' into feat/error-logging
danielroe Aug 10, 2022
7146682
Merge branch 'main' into feat/error-logging
pi0 Aug 11, 2022
ff4f9c5
refactor: extract shared formatter
danielroe Aug 25, 2022
7a40a24
Merge remote-tracking branch 'origin/main' into feat/error-logging
danielroe Aug 25, 2022
4fe0ac1
fix: return all logs
danielroe Aug 25, 2022
6f25783
style: revert unneeded change
danielroe Aug 25, 2022
158b52c
style: lint
danielroe Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,8 @@ async function _build (nitro: Nitro, rollupConfig: RollupConfig) {

nitro.logger.start('Building server...')
const build = await rollup.rollup(rollupConfig).catch((error) => {
nitro.logger.error('Rollup error: ' + error.message)
const location = `${relative(process.cwd(), error.id)}:${error.loc.line}:${error.loc.column}`
nitro.logger.error(`Rollup error while parsing \`${location}\`` + '\n' + '\n' + error.frame)
throw error
})

Expand Down