Skip to content

fix: add code location and codeframe for rollup errors #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Aug 31, 2022
Merged

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Aug 10, 2022

πŸ”— Linked issue

resolves #165

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR adds clickable code location and codeframe for rollup build errors.


CleanShot 2022-08-10 at 14 22 39


CleanShot 2022-08-10 at 21 38 46@2x

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Aug 10, 2022
@danielroe danielroe requested a review from pi0 August 10, 2022 13:25
@danielroe danielroe self-assigned this Aug 10, 2022
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #406 (158b52c) into main (d1d1015) will decrease coverage by 0.30%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
- Coverage   53.59%   53.29%   -0.31%     
==========================================
  Files          54       54              
  Lines        3502     3522      +20     
  Branches      370      370              
==========================================
  Hits         1877     1877              
- Misses       1268     1288      +20     
  Partials      357      357              
Impacted Files Coverage Ξ”
src/build.ts 45.03% <65.21%> (-3.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danielroe danielroe requested a review from pi0 August 10, 2022 13:52
@pi0 pi0 changed the title feat: add code location and codeframe for rollup errors fix: add code location and codeframe for rollup errors Aug 10, 2022
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit b99547b into main Aug 31, 2022
@pi0 pi0 deleted the feat/error-logging branch August 31, 2022 19:26
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add code location to rollup errors
2 participants