-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more linters #2092
Add more linters #2092
Conversation
a8c0709
to
6dfdcdd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2092 +/- ##
==========================================
- Coverage 87.61% 87.59% -0.03%
==========================================
Files 96 96
Lines 6695 6698 +3
Branches 50 50
==========================================
+ Hits 5866 5867 +1
- Misses 773 774 +1
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
Also wondering what you think about the suggested |
75995be
to
061a5ba
Compare
I'm fine with it. It will be a good reminder for us to try and preallocate when the capacity can be determined, which is in our coding guidelines. |
803d5c7
to
344345a
Compare
I've decided to open a sepate PR for |
Problem: We want to catch errors and styling issues as early as possible. Solution: Enable new linters.
3423adf
to
54a4f0e
Compare
Problem: We want to catch errors and styling issues as early as possible. Solution: Enable new linters.
Proposed changes
Problem: We want to catch errors and styling issues as early as possible.
Solution: Enable new linters.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.