Merge branch 'main' into chore/more-linters

lucacome · web-flow · commit 75995be7616f · 2024-06-05T18:21:39.000-07:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -170,7 +170,7 @@ jobs:
         if: github.ref_type == 'tag'
 
       - name: Build binary
-        uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0
+        uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0
         with:
           version: latest
           args: ${{ github.ref_type == 'tag' && 'release' || 'build --snapshot' }} --clean
diff --git a/.github/workflows/conformance.yml b/.github/workflows/conformance.yml
@@ -77,7 +77,7 @@ jobs:
         working-directory: ./tests
 
       - name: Build binary
-        uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0
+        uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0
         with:
           version: latest
           args: build --snapshot --clean
diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
@@ -15,6 +15,6 @@ jobs:
         uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
 
       - name: "Dependency Review"
-        uses: actions/dependency-review-action@0c155c5e8556a497adf53f2c18edabf945ed8e70 # v4.3.2
+        uses: actions/dependency-review-action@72eb03d02c7872a771aacd928f3123ac62ad6d3a # v4.3.3
         with:
           config-file: "nginxinc/k8s-common/dependency-review-config.yml@main"
diff --git a/.github/workflows/functional.yml b/.github/workflows/functional.yml
@@ -65,7 +65,7 @@ jobs:
             type=ref,event=branch,suffix=-rc,enable=${{ startsWith(github.ref, 'refs/heads/release') }}
 
       - name: Build binary
-        uses: goreleaser/goreleaser-action@5742e2a039330cbb23ebf35f046f814d4c6ff811 # v5.1.0
+        uses: goreleaser/goreleaser-action@286f3b13b1b49da4ac219696163fb8c1c93e1200 # v6.0.0
         with:
           version: latest
           args: build --snapshot --clean
diff --git a/.goreleaser.yml b/.goreleaser.yml
@@ -1,3 +1,4 @@
+version: 2
 env:
   - CGO_ENABLED=0
 
@@ -26,7 +27,7 @@ builds:
     binary: gateway
 
 changelog:
-  skip: true
+  disable: true
 
 archives:
   - id: gateway
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -33,7 +33,7 @@ repos:
     hooks:
       - id: prettier
         additional_dependencies:
-          - prettier@3.3.0 # https://github.com/pre-commit/pre-commit/issues/3133
+          - prettier@3.3.1 # https://github.com/pre-commit/pre-commit/issues/3133
         types:
           - javascript
 
diff --git a/go.mod b/go.mod
@@ -23,7 +23,7 @@ require (
 	k8s.io/apiextensions-apiserver v0.30.1
 	k8s.io/apimachinery v0.30.1
 	k8s.io/client-go v0.30.1
-	sigs.k8s.io/controller-runtime v0.18.3
+	sigs.k8s.io/controller-runtime v0.18.4
 	sigs.k8s.io/controller-tools v0.15.0
 	sigs.k8s.io/gateway-api v1.1.0
 )
diff --git a/go.sum b/go.sum
@@ -239,8 +239,8 @@ k8s.io/kube-openapi v0.0.0-20240423202451-8948a665c108 h1:Q8Z7VlGhcJgBHJHYugJ/K/
 k8s.io/kube-openapi v0.0.0-20240423202451-8948a665c108/go.mod h1:yD4MZYeKMBwQKVht279WycxKyM84kkAx2DPrTXaeb98=
 k8s.io/utils v0.0.0-20240423183400-0849a56e8f22 h1:ao5hUqGhsqdm+bYbjH/pRkCs0unBGe9UyDahzs9zQzQ=
 k8s.io/utils v0.0.0-20240423183400-0849a56e8f22/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
-sigs.k8s.io/controller-runtime v0.18.3 h1:B5Wmmo8WMWK7izei+2LlXLVDGzMwAHBNLX68lwtlSR4=
-sigs.k8s.io/controller-runtime v0.18.3/go.mod h1:TVoGrfdpbA9VRFaRnKgk9P5/atA0pMwq+f+msb9M8Sg=
+sigs.k8s.io/controller-runtime v0.18.4 h1:87+guW1zhvuPLh1PHybKdYFLU0YJp4FhJRmiHvm5BZw=
+sigs.k8s.io/controller-runtime v0.18.4/go.mod h1:TVoGrfdpbA9VRFaRnKgk9P5/atA0pMwq+f+msb9M8Sg=
 sigs.k8s.io/controller-tools v0.15.0 h1:4dxdABXGDhIa68Fiwaif0vcu32xfwmgQ+w8p+5CxoAI=
 sigs.k8s.io/controller-tools v0.15.0/go.mod h1:8zUSS2T8Hx0APCNRhJWbS3CAQEbIxLa07khzh7pZmXM=
 sigs.k8s.io/gateway-api v1.1.0 h1:DsLDXCi6jR+Xz8/xd0Z1PYl2Pn0TyaFMOPPZIj4inDM=
diff --git a/internal/mode/static/nginx/modules/package-lock.json b/internal/mode/static/nginx/modules/package-lock.json
diff --git a/internal/mode/static/nginx/modules/package.json b/internal/mode/static/nginx/modules/package.json
@@ -11,7 +11,7 @@
   },
   "devDependencies": {
     "@vitest/coverage-v8": "^1.6.0",
-    "prettier": "3.3.0",
+    "prettier": "3.3.1",
     "vitest": "^1.5.3"
   },
   "type": "module"
diff --git a/tests/framework/resourcemanager.go b/tests/framework/resourcemanager.go
@@ -398,6 +398,13 @@ func (rm *ResourceManager) waitForHTTPRoutesToBeReady(ctx context.Context, names
 }
 
 func (rm *ResourceManager) waitForGRPCRoutesToBeReady(ctx context.Context, namespace string) error {
+	// First, check if grpcroute even exists for v1. If not, ignore.
+	var routeList v1.GRPCRouteList
+	err := rm.K8sClient.List(ctx, &routeList, client.InNamespace(namespace))
+	if err != nil && strings.Contains(err.Error(), "no matches for kind") {
+		return nil
+	}
+
 	return wait.PollUntilContextCancel(
 		ctx,
 		500*time.Millisecond,
diff --git a/tests/go.mod b/tests/go.mod
@@ -13,7 +13,7 @@ require (
 	k8s.io/apiextensions-apiserver v0.30.1
 	k8s.io/apimachinery v0.30.1
 	k8s.io/client-go v0.30.1
-	sigs.k8s.io/controller-runtime v0.18.3
+	sigs.k8s.io/controller-runtime v0.18.4
 	sigs.k8s.io/gateway-api v1.1.0
 	sigs.k8s.io/yaml v1.4.0
 )
diff --git a/tests/go.sum b/tests/go.sum
@@ -208,8 +208,8 @@ k8s.io/utils v0.0.0-20240423183400-0849a56e8f22 h1:ao5hUqGhsqdm+bYbjH/pRkCs0unBG
 k8s.io/utils v0.0.0-20240423183400-0849a56e8f22/go.mod h1:OLgZIPagt7ERELqWJFomSt595RzquPNLL48iOWgYOg0=
 pgregory.net/rapid v1.1.0 h1:CMa0sjHSru3puNx+J0MIAuiiEV4N0qj8/cMWGBBCsjw=
 pgregory.net/rapid v1.1.0/go.mod h1:PY5XlDGj0+V1FCq0o192FdRhpKHGTRIWBgqjDBTrq04=
-sigs.k8s.io/controller-runtime v0.18.3 h1:B5Wmmo8WMWK7izei+2LlXLVDGzMwAHBNLX68lwtlSR4=
-sigs.k8s.io/controller-runtime v0.18.3/go.mod h1:TVoGrfdpbA9VRFaRnKgk9P5/atA0pMwq+f+msb9M8Sg=
+sigs.k8s.io/controller-runtime v0.18.4 h1:87+guW1zhvuPLh1PHybKdYFLU0YJp4FhJRmiHvm5BZw=
+sigs.k8s.io/controller-runtime v0.18.4/go.mod h1:TVoGrfdpbA9VRFaRnKgk9P5/atA0pMwq+f+msb9M8Sg=
 sigs.k8s.io/gateway-api v1.1.0 h1:DsLDXCi6jR+Xz8/xd0Z1PYl2Pn0TyaFMOPPZIj4inDM=
 sigs.k8s.io/gateway-api v1.1.0/go.mod h1:ZH4lHrL2sDi0FHZ9jjneb8kKnGzFWyrTya35sWUTrRs=
 sigs.k8s.io/json v0.0.0-20221116044647-bc3834ca7abd h1:EDPBXCAspyGV4jQlpZSudPeMmr1bNJefnuqLsRAsHZo=
diff --git a/tests/suite/tracing_test.go b/tests/suite/tracing_test.go
@@ -22,7 +22,10 @@ import (
 	"github.com/nginxinc/nginx-gateway-fabric/tests/framework"
 )
 
-var _ = Describe("Tracing", Label("functional", "tracing"), func() {
+// This test can be flaky when waiting to see traces show up in the collector logs.
+// Sometimes they get there right away, sometimes it takes 30 seconds. Retries were
+// added to attempt to mitigate the issue, but it didn't fix it 100%
+var _ = Describe("Tracing", FlakeAttempts(2), Label("functional", "tracing"), func() {
 	var (
 		files = []string{
 			"hello-world/apps.yaml",

-Original file line number
+Diff line change
     hooks:
       - id: prettier
         additional_dependencies:
 -          - [email protected].0 # https://github.com/pre-commit/pre-commit/issues/3133
 +          - [email protected].1 # https://github.com/pre-commit/pre-commit/issues/3133
         types:
           - javascript
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ require (`
`23`	`23`	`k8s.io/apiextensions-apiserver v0.30.1`
`24`	`24`	`k8s.io/apimachinery v0.30.1`
`25`	`25`	`k8s.io/client-go v0.30.1`
`26`		`- sigs.k8s.io/controller-runtime v0.18.3`
	`26`	`+ sigs.k8s.io/controller-runtime v0.18.4`
`27`	`27`	`sigs.k8s.io/controller-tools v0.15.0`
`28`	`28`	`sigs.k8s.io/gateway-api v1.1.0`
`29`	`29`	`)`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@ require (`
`13`	`13`	`k8s.io/apiextensions-apiserver v0.30.1`
`14`	`14`	`k8s.io/apimachinery v0.30.1`
`15`	`15`	`k8s.io/client-go v0.30.1`
`16`		`- sigs.k8s.io/controller-runtime v0.18.3`
	`16`	`+ sigs.k8s.io/controller-runtime v0.18.4`
`17`	`17`	`sigs.k8s.io/gateway-api v1.1.0`
`18`	`18`	`sigs.k8s.io/yaml v1.4.0`
`19`	`19`	`)`