-
Notifications
You must be signed in to change notification settings - Fork 868
Add parabricks-minimap2 module #8649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good some minor additions and one request :)
assertAll( | ||
{ assert process.success }, | ||
{ assert snapshot( | ||
cram(process.out.cram[0][1]).getReadsMD5(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work??? I thought we ususally need to hand the fasta file to get the READSMD5 for cram files 🤔
tuple val(meta3), path(interval_file) | ||
tuple val(meta4), path(known_sites) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are empty for all your tests. Can you please add tests with interval_file and known_sites? :)
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
Co-authored-by: Famke Bäuerle <[email protected]>
PR checklist
Closes #8626
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda