-
Notifications
You must be signed in to change notification settings - Fork 870
Add the deacon/index tool. #8640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The container seems to have on apple sillicon, so I tested this locally using conda.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall look good :)
modules/nf-core/deacon/index/main.nf
Outdated
|
||
script: | ||
def args = task.ext.args ?: '' | ||
def prefix = task.ext.prefix ?: "${fasta.baseName}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, I was just tinkering with that I forgot to flip back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected - dcbb35e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, just a minor comment
The container seems to have issues on apple silicon, so I tested this locally using conda.
PR checklist
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
-> tested using a custom container (I'll follow up with the devs - the bioconda container is not working on apple silicon -- I suspect it's related to how the package was compiled in bioconda)nf-core modules test <MODULE> --profile singularity
-> I don't have it locally (tricky to install on an M4)nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda