Skip to content

Add the deacon/index tool. #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 16, 2025
Merged

Conversation

mberacochea
Copy link
Contributor

@mberacochea mberacochea commented Jun 15, 2025

The container seems to have issues on apple silicon, so I tested this locally using conda.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker -> tested using a custom container (I'll follow up with the devs - the bioconda container is not working on apple silicon -- I suspect it's related to how the package was compiled in bioconda)
      • nf-core modules test <MODULE> --profile singularity -> I don't have it locally (tricky to install on an M4)
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

The container seems to have on apple sillicon, so I tested this locally using conda.
@mberacochea mberacochea changed the title Add the deacon/ / index tool. Add the deacon/index tool. Jun 15, 2025
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall look good :)


script:
def args = task.ext.args ?: ''
def prefix = task.ext.prefix ?: "${fasta.baseName}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick
This should not be modified (should remain meta.id) unless there is a spceific reason you did this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, I was just tinkering with that I forgot to flip back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected - dcbb35e

Copy link
Contributor

@vagkaratzas vagkaratzas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a minor comment

@mberacochea mberacochea enabled auto-merge June 16, 2025 11:49
@mberacochea mberacochea added this pull request to the merge queue Jun 16, 2025
Merged via the queue into nf-core:master with commit 596fc4c Jun 16, 2025
27 checks passed
@mberacochea mberacochea deleted the module/deacon-index branch June 16, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants