-
Notifications
You must be signed in to change notification settings - Fork 870
Cooltools insulation #3634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Cooltools insulation #3634
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably the .tsv file varies every time you run it, else it would have a md5sum in the .yml, but you should be able to use contains to check for a word in it.
Bumping the PR, it looks like it is virtually ready, can we get it finished off? |
@nservant, I've updated this to nf-test. I have also swapped to just a cooltools container rather than the mulled one; if this is an issue then seqera containers will be the answer once we have that fully up and running. I think the only thing outstanding is that the test-data is using a github link, which we would like to avoid. So we'd rather use the cooler test data that already exists in the git repo (perhaps put through another tool as a setup requirement), or add some new test data. I tried swapping to the |
Bump :) |
To be honest, I'm tempted to just merge this here with an external github link. |
The meta.yml linting also needs to be fixed so :/ |
Eh, that is doable. |
Hi guys, @SPPearce
Otherwise, we can add an additional normalized dataset in |
@nservant If its small test data I would be in favor of adding it to our own test-datasets github if there is no other suitable data available over there |
So we can use the same tool to make a correct input for this one? We could just do that inside the nf-test then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add ontologies to the meta.yml file (https://nf-co.re/blog/2025/modules-ontology)
Co-authored-by: Simon Pearce <[email protected]>
Co-authored-by: Simon Pearce <[email protected]>
add edam ontologies
Hello @SPPearce, I updated the edam ontologies and did the other corrections. I couldn't find an ontology for .cool files, does it exist? |
Absolutely no idea, I don't know anything about the ontologies, some other people care more than me about this. The way to add things seems to be detailed here . |
fix testdata_path param
fix params in main.nf
update cooltools version
Co-authored-by: Simon Pearce <[email protected]>
new modules
cooltools/insulation
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware