fix: Capture potential missing tail data for session trace #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #624 +/- ##
==========================================
+ Coverage 69.94% 69.95% +0.01%
==========================================
Files 134 134
Lines 5995 5988 -7
Branches 1141 1139 -2
==========================================
- Hits 4193 4189 -4
+ Misses 1487 1486 -1
+ Partials 315 313 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Asset Size ReportMerging this pull request will result in the following CDN asset size changes:
Merging this pull request will result in the following NPM package consumer size changes:
Other Standard CDN AssetsReleased Assets
Built Assets
Other Polyfill CDN AssetsReleased Assets
Built Assets
|
metal-messiah
added
the
needs follow up
cwli24
commented
Aug 16, 2023
patrickhousley
removed
the
needs follow up
|
I verified the safari tests that failed in github actions are passing locally. They appear to just be flakey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send buffered session trace data in certain cases when it's being discarded at the tail end of a captured session.
Overview
In the old session trace behavior, it had discarded or not sent remaining session trace nodes when it hit the max duration life of the feature, even though the nodes were added before the max duration time. Likewise, on EoL of the page, session trace would not run final harvest if the buffered nodes is less than the required minimum of 30, which causes that valid data to be amiss. This PR patches both of those issues.
Related Issue(s)
NR-138555
Testing
Workflows listed in bug ticket's AC list should hold true, namely: