Skip to content

Ewm4848 migrate to run number dao for backend validation #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/snapred/backend/dao/state/RunNumber.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
from pydantic import BaseModel, Field, validator

from snapred.backend.log.logger import snapredLogger
from snapred.meta.validator.RunNumberValidator import RunNumberValidator

logger = snapredLogger.getLogger(__name__)


class RunNumber(BaseModel):
runNumber: int = Field(..., description="The run number provided by the user for reduction.")

@validator("runNumber", pre=True, always=True)
def validateRunNumber(cls, value):
# Check if run number is an integer
if not isinstance(value, int):
logger.error("Run number must be an integer.")
raise ValueError("Run number must be an integer. Please enter a valid run number.")

# Use RunNumberValidator to check the minimum run number and cached data existence
if not RunNumberValidator.validateRunNumber(str(value)):
logger.error("Run number does not meet the minimum required value or does not have cached data available.")
raise ValueError(
"Run number is below the minimum value or data does not exist. Please enter a valid run number."
)

return value