Ewm4848 migrate to run number dao for backend validation #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #453 +/- ##
=======================================
Coverage 95.86% 95.86%
=======================================
Files 61 61
Lines 4429 4429
=======================================
Hits 4246 4246
Misses 183 183 ☔ View full report in Codecov by Sentry. |
dlcaballero16
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This story includes the implementation of a RunNumber DAO that can be used for validation within the backend of SNAPRed. This story went through some scope changes based on a discussion between Michael and I.
Explanation of work
This ended up being a simple implementation of
RunNumberValidation.pywithin this new DAO object. Since the outlying cases of checking for state, diffcal and nrmcal were delegated to be checked per request basis, this ended up being much simpler than expected.To test
Insure all pytests pass. Check the code, this hasn't been implemented within the code base yet, this is a creation story.
Link to EWM item
EWM # 4848