Skip to content

stree: Reduce allocations in matchParts #6837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
+4 −1
Merged

stree: Reduce allocations in matchParts #6837

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion server/stree/parts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,10 @@ func matchParts(parts [][]byte, frag []byte) ([][]byte, bool) {
// but update the part to what was consumed. This allows upper layers to continue.
if end < si+lp {
if end >= lf {
parts = append([][]byte{}, parts...) // Create a copy before modifying.
// Create a copy before modifying. Reuse slice capacity available at the
// end of the parts slice, since this saves us additional allocations.
lp := len(parts)
parts = append(parts[lp:], parts[:lp]...)
parts[i] = parts[i][lf-si:]
} else {
i++
Expand Down