stree: Reduce allocations in matchParts
#6837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More often than not, if we need to copy when matching, we're potentially wasting free capacity at the end of the existing
partsslice. Instead of allocating a whole new slice, attempt to reuse that capacity. If it overflows into a reallocation then that's not the end of the world, as there should now be more available capacity for the next iteration too.This is safe to do as in the
matchfunction,partsis not modified at any point before the next call tomatchParts, therefore unused capacity is not going to be overwritten.Signed-off-by: Neil Twigg [email protected]