-
Notifications
You must be signed in to change notification settings - Fork 143
[ISSUE #1368]📝Update README.md #1369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes in this pull request involve updates to the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
🔊@mxsm 🚀Thanks for your contribution 🎉. CodeRabbit(AI) will review your code first 🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
README.md (2)
25-25
: Remove trailing period from headingThe content providing version base information is valuable. However, to follow markdown conventions, remove the trailing period from the heading.
-### **🔊Note**: ***Rocketmq-rust*** is implemented based on ***Apache Rocketmq release-5.3.1📌(Tag)***, with subsequent feature enhancements to follow the updates of the version🚩. +### **🔊Note**: ***Rocketmq-rust*** is implemented based on ***Apache Rocketmq release-5.3.1📌(Tag)***, with subsequent feature enhancements to follow the updates of the version🚩🧰 Tools
🪛 Markdownlint (0.35.0)
25-25: Punctuation: '.'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
Line range hint
27-42
: Consider using quarters instead of specific dates for future releasesThe roadmap table is well-structured and provides excellent transparency. However, for future releases (v0.4.0 onwards), consider using quarters (e.g., "Q1 2025") instead of specific dates. This provides more flexibility while maintaining clear expectations.
The current structure with specific dates might create unnecessary pressure to meet exact deadlines, especially for releases planned far into the future.
| 🔖v0.1.0 | 🚩2024-01-28 | Released🎉 | | 🔖v0.2.0 | 🚩2024-06-05 | Released🎉 | | 🔖v0.3.0 | 🚩2024-11-17 | Released🎉 | -| 🔖v0.4.0 | 🚩2025-02-17 | 🚧 | -| 🔖v0.5.0 | 🚩2025-05-17 | 🚧 | -| 🔖v0.6.0 | 🚩2025-08-17 | 🚧 | +| 🔖v0.4.0 | 🚩Q1 2025 | 🚧 | +| 🔖v0.5.0 | 🚩Q2 2025 | 🚧 | +| 🔖v0.6.0 | 🚩Q3 2025 | 🚧 |🧰 Tools
🪛 LanguageTool
[style] ~30-~30: Consider using a different verb for a more formal wording.
Context: ...ase a new version every three months to fix issues. If there are major updates or n...(FIX_RESOLVE)
🪛 Markdownlint (0.35.0)
25-25: Punctuation: '.'
Trailing punctuation in heading(MD026, no-trailing-punctuation)
28-28: null
Images should have alternate text (alt text)(MD045, no-alt-text)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 Markdownlint (0.35.0)
README.md
25-25: Punctuation: '.'
Trailing punctuation in heading
(MD026, no-trailing-punctuation)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1369 +/- ##
=======================================
Coverage 21.03% 21.03%
=======================================
Files 434 434
Lines 55191 55191
=======================================
Hits 11611 11611
Misses 43580 43580 ☔ View full report in Codecov by Sentry. |
Which Issue(s) This PR Fixes(Closes)
Fixes #1368
Brief Description
How Did You Test This Change?
Summary by CodeRabbit