Skip to content

[ISSUE #1328]🧪Add test for ConsumerData #1329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

[ISSUE #1328]🧪Add test for ConsumerData #1329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions rocketmq-remoting/src/protocol/heartbeat/consumer_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,105 @@ impl Hash for ConsumerData {
self.unit_mode.hash(state);
}
}

#[cfg(test)]
mod tests {
use std::collections::HashSet;

use cheetah_string::CheetahString;
use rocketmq_common::common::consumer::consume_from_where::ConsumeFromWhere;

use super::*;
use crate::protocol::heartbeat::consume_type::ConsumeType;
use crate::protocol::heartbeat::message_model::MessageModel;
use crate::protocol::heartbeat::subscription_data::SubscriptionData;

#[test]
fn consumer_data_default_values() {
let consumer_data = ConsumerData::default();
assert_eq!(consumer_data.group_name, CheetahString::new());
assert_eq!(consumer_data.consume_type, ConsumeType::default());
assert_eq!(consumer_data.message_model, MessageModel::default());
assert_eq!(
consumer_data.consume_from_where,
ConsumeFromWhere::default()
);
assert!(consumer_data.subscription_data_set.is_empty());
assert!(!consumer_data.unit_mode);
}

#[test]
fn consumer_data_equality() {
let mut subscription_data_set = HashSet::new();
subscription_data_set.insert(SubscriptionData::default());

let consumer_data1 = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: subscription_data_set.clone(),
unit_mode: false,
};

let consumer_data2 = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set,
unit_mode: false,
};

assert_eq!(consumer_data1, consumer_data2);
}

#[test]
fn consumer_data_inequality() {
let consumer_data1 = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};

let consumer_data2 = ConsumerData {
group_name: CheetahString::from("group2"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};

assert_ne!(consumer_data1, consumer_data2);
}
Comment on lines +105 to +126
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Expand inequality test coverage

The test only verifies inequality for different group names. Consider testing inequality for:

  • Different consume_type values
  • Different message_model values
  • Different consume_from_where values
  • Different subscription_data_set contents
  • Different unit_mode values
 #[test]
 fn consumer_data_inequality() {
+    let base_consumer = ConsumerData {
+        group_name: CheetahString::from("group1"),
+        consume_type: ConsumeType::default(),
+        message_model: MessageModel::default(),
+        consume_from_where: ConsumeFromWhere::default(),
+        subscription_data_set: HashSet::new(),
+        unit_mode: false,
+    };
+
+    // Test inequality for each field
     let consumer_data1 = ConsumerData {
-        group_name: CheetahString::from("group1"),
-        consume_type: ConsumeType::default(),
-        message_model: MessageModel::default(),
-        consume_from_where: ConsumeFromWhere::default(),
-        subscription_data_set: HashSet::new(),
-        unit_mode: false,
+        group_name: CheetahString::from("group2"),
+        ..base_consumer.clone()
     };
+    assert_ne!(base_consumer, consumer_data1);

     let consumer_data2 = ConsumerData {
-        group_name: CheetahString::from("group2"),
-        consume_type: ConsumeType::default(),
-        message_model: MessageModel::default(),
-        consume_from_where: ConsumeFromWhere::default(),
-        subscription_data_set: HashSet::new(),
-        unit_mode: false,
+        consume_type: ConsumeType::PASSIVELY,
+        ..base_consumer.clone()
     };
+    assert_ne!(base_consumer, consumer_data2);

-    assert_ne!(consumer_data1, consumer_data2);
+    let consumer_data3 = ConsumerData {
+        message_model: MessageModel::BROADCASTING,
+        ..base_consumer.clone()
+    };
+    assert_ne!(base_consumer, consumer_data3);
+
+    let mut subscription_set = HashSet::new();
+    let mut sub = SubscriptionData::default();
+    sub.topic = CheetahString::from("topic1");
+    subscription_set.insert(sub);
+    let consumer_data4 = ConsumerData {
+        subscription_data_set: subscription_set,
+        ..base_consumer.clone()
+    };
+    assert_ne!(base_consumer, consumer_data4);
+
+    let consumer_data5 = ConsumerData {
+        unit_mode: true,
+        ..base_consumer
+    };
+    assert_ne!(base_consumer, consumer_data5);
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#[test]
fn consumer_data_inequality() {
let consumer_data1 = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};
let consumer_data2 = ConsumerData {
group_name: CheetahString::from("group2"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};
assert_ne!(consumer_data1, consumer_data2);
}
#[test]
fn consumer_data_inequality() {
let base_consumer = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};
// Test inequality for each field
let consumer_data1 = ConsumerData {
group_name: CheetahString::from("group2"),
..base_consumer.clone()
};
assert_ne!(base_consumer, consumer_data1);
let consumer_data2 = ConsumerData {
consume_type: ConsumeType::PASSIVELY,
..base_consumer.clone()
};
assert_ne!(base_consumer, consumer_data2);
let consumer_data3 = ConsumerData {
message_model: MessageModel::BROADCASTING,
..base_consumer.clone()
};
assert_ne!(base_consumer, consumer_data3);
let mut subscription_set = HashSet::new();
let mut sub = SubscriptionData::default();
sub.topic = CheetahString::from("topic1");
subscription_set.insert(sub);
let consumer_data4 = ConsumerData {
subscription_data_set: subscription_set,
..base_consumer.clone()
};
assert_ne!(base_consumer, consumer_data4);
let consumer_data5 = ConsumerData {
unit_mode: true,
..base_consumer
};
assert_ne!(base_consumer, consumer_data5);
}


#[test]
fn consumer_data_hash() {
use std::collections::hash_map::DefaultHasher;
use std::hash::Hash;
use std::hash::Hasher;

let consumer_data = ConsumerData {
group_name: CheetahString::from("group1"),
consume_type: ConsumeType::default(),
message_model: MessageModel::default(),
consume_from_where: ConsumeFromWhere::default(),
subscription_data_set: HashSet::new(),
unit_mode: false,
};

let mut hasher = DefaultHasher::new();
consumer_data.hash(&mut hasher);
let hash1 = hasher.finish();

let mut hasher = DefaultHasher::new();
consumer_data.hash(&mut hasher);
let hash2 = hasher.finish();

assert_eq!(hash1, hash2);
}
}
Loading