Skip to content

[infra] Use playwright docker image #18186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 2, 2025

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jun 2, 2025

Revert changes introduced in #17214, since we no longer use mocha and tests work on vitest with Node 22.

Allowed by #18071.

This should hopefully avoid the insanely flaky CI lately. 🙈

@LukasTy LukasTy self-assigned this Jun 2, 2025
@LukasTy LukasTy added type: enhancement This is not a bug, nor a new feature scope: code-infra Specific to the code-infra product labels Jun 2, 2025
@mui-bot
Copy link

mui-bot commented Jun 2, 2025

Deploy preview: https://deploy-preview-18186--material-ui-x.netlify.app/

Bundle size report

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%)
Files: 120 total (0 added, 0 removed, 0 changed)

Details of bundle changes

Generated by 🚫 dangerJS against f5b991c

@JCQuintas
Copy link
Member

Need to remove the entire condition: << parameters.playwright >> block

@JCQuintas
Copy link
Member

@LukasTy it is possible ffmpeg is not available as a global on the image, we might need to add part of 62f9c64 back

@LukasTy
Copy link
Member Author

LukasTy commented Jun 2, 2025

@JCQuintas f5b991c 🙈

@JCQuintas
Copy link
Member

@JCQuintas f5b991c 🙈

We might actually do what we did before which was to link the playwright one globally, as our issue is downloading from the Ubuntu archive, which this would still be doing 😅

@LukasTy
Copy link
Member Author

LukasTy commented Jun 2, 2025

@JCQuintas f5b991c 🙈

We might actually do what we did before which was to link the playwright one globally, as our issue is downloading from the Ubuntu archive, which this would still be doing 😅

Yes, but this does benefit from the CircleCI caching and often uses the existing cache instead of pulling a fresh container. 🤔
This setup worked before, but we moved away from it due to incompatibility with tests not working with CSS loading. 🙈

@JCQuintas
Copy link
Member

Argos changes mostly due to system changes, there are some changes related to print dialog, but I find them acceptable.

@LukasTy LukasTy marked this pull request as ready for review June 2, 2025 13:43
@LukasTy
Copy link
Member Author

LukasTy commented Jun 2, 2025

Argos changes mostly due to system changes, there are some changes related to print dialog, but I find them acceptable.

Agreed.
It's only charts export and data grid export tests that have actual diffs, due to window differences.
Everything else is text/font aliasing setting dependent. 🤷

@LukasTy LukasTy merged commit b155519 into mui:master Jun 2, 2025
22 checks passed
@LukasTy LukasTy deleted the ci-use-playwright-docker-image branch June 2, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the code-infra product type: enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants