[code-infra] Replace mocha with vitest on e2e and regression tests
#18071
Conversation
JCQuintas
added
core
|
Thanks for adding a type label to the PR! 👍 |
|
Deploy preview: https://deploy-preview-18071--material-ui-x.netlify.app/ Bundle size reportTotal Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%) |
JCQuintas
changed the title
mocha with vitest on e2e tests
Signed-off-by: Jose C Quintas Jr <[email protected]>
JCQuintas
changed the title
mocha with vitest on e2e testsmocha with vitest on e2e and regression tests
| @@ -6,6 +6,34 @@ import react from '@vitejs/plugin-react'; | |||
| const CURRENT_DIR = dirname(fileURLToPath(import.meta.url)); | |||
| const WORKSPACE_ROOT = resolve(CURRENT_DIR, './'); | |||
|
|
|||
| export const alias = [ | |||
There was a problem hiding this comment.
How do you feel about vite-tsconfig-paths?
There was a problem hiding this comment.
Nothing against it if it works. I can try it in a different pr
| "mocha": "mocha --config .mocharc.js '**/*.test.{js,ts,tsx}'", | ||
| "server": "serve . -p 5001" | ||
| "test": "vitest", | ||
| "server": "serve . -L -p 5001" |
There was a problem hiding this comment.
Why do we need this -L flag? Is it a leftover from tests you made or is it mean to be kept?
There was a problem hiding this comment.
-L is to omit the server logs, which make the CI logs very verbose. We generally want to know if the tests passed or if there was an error on them, not that the server is working as expected.
| testTimeout: 20000, | ||
| hookTimeout: 20000, |
There was a problem hiding this comment.
We also seem to be setting timeouts in line 112 of index.test.ts. Would it make sense to move all the timeout set up here so that it's centralized?
There was a problem hiding this comment.
Sadly these are different timeouts, one is vitest, another is playwright 🫠
not yet, was going to work on it next 😅 |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Jose C Quintas Jr <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
Plan
Will try to remove mocha types in a final PR