[test] Sync regression test layout with Base UI / Material UI #17564

oliviertassinari · 2025-04-26T23:32:52Z

I wanted to run the regression tests in dev mode to debug #17538.

But since #17214, it's no longer possible. I'm bringing this back, progressively making Base UI the gold reference (rather than Material UI) for code-infra.

github-actions · 2025-04-26T23:33:04Z

Thanks for adding a type label to the PR! 👍

mui-bot · 2025-04-26T23:36:19Z

Deploy preview: https://deploy-preview-17564--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 60a3728

romgrk · 2025-04-27T11:47:01Z

test/regressions/.mocharc.cjs

Wouldn't we want to move towards ESM? I'd bring the changes here to the core instead of the other way around.

Also, right now the e2e & regression setups are close mirrors of each other, if we change one of them we should change both. This applies for .mocharc, vite.config.js and package.json.

Wouldn't we want to move towards ESM?

Yeah, but if you run pnpm run mocha in HEAD from the /test/regressions folder, it crash on ESM vs. CJS import conflict, which seems expected since we set "type": "module", in that folder package but not in the root package. So I think it's a bug fix.

if we change one of them we should change both. This applies for .mocharc, vite.config.js and package.json.

The priority seems reversed, if there is something to copy it's first Base UI or Material UI, and second MUI X.

Why not rename to the file to .mjs instead then?

The priority seems reversed, if there is something to copy it's first Base UI or Material UI, and second MUI X.

What I meant is that in X, test/regressions and test/e2e are very similar. Same file/folder layout, same npm scripts. If we're applying changes to one of those folders, they should be applied to both folders.

romgrk · 2025-04-27T11:49:47Z

package.json

In #17214 I tried to move deps & config towards where they're used. Calling the commands such as mocha from the root means we need all the deps for all the test setups (unit, regressions, e2e) mashed into the root package.json.

Ok, a variant of this PR: #17583, but I don't really see the value, having the same depends between the different test env seems OK.

romgrk · 2025-04-27T11:54:38Z

test/regressions/vite.config.js

+      '@mui/x-data-grid': path.resolve(import.meta.dirname, '../../packages/x-data-grid/src'),
+      '@mui/x-data-grid-generator': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-generator/src',
+      ),
+      '@mui/x-data-grid-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-pro/src',
+      ),
+      '@mui/x-data-grid-premium': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-premium/src',
+      ),
+      '@mui/x-date-pickers': path.resolve(import.meta.dirname, '../../packages/x-date-pickers/src'),
+      '@mui/x-date-pickers-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-date-pickers-pro/src',
+      ),
+      '@mui/x-charts': path.resolve(import.meta.dirname, '../../packages/x-charts/src'),
+      '@mui/x-charts-pro': path.resolve(import.meta.dirname, '../../packages/x-charts-pro/src'),
+      '@mui/x-tree-view': path.resolve(import.meta.dirname, '../../packages/x-tree-view/src'),
+      '@mui/x-tree-view-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-tree-view-pro/src',
+      ),
+      '@mui/x-license': path.resolve(import.meta.dirname, '../../packages/x-license/src'),
+      '@mui/x-telemetry': path.resolve(import.meta.dirname, '../../packages/x-telemetry/src'),
+      '@mui/x-internals': path.resolve(import.meta.dirname, '../../packages/x-internals/src'),
+      '@mui/material-nextjs': path.resolve(
+        import.meta.dirname,
+        '../../node_modules/@mui/monorepo/packages/mui-material-nextjs/src',
+      ),
+      docs: path.resolve(import.meta.dirname, '../../node_modules/@mui/monorepo/docs'),


I have tried to move away from alias lists. If we do want them back, we should probably find a way to avoid having multiple copies of it.

Without this, we have to build the whole project and have it in watch mode to debug/run the visual regression tests, which feels super slow (+200s on my end). Too slow to be usable in practice. #17584

https://github.com/mui/base-ui/blob/a7451a08424f12d913c8355cccf3274ef5f3e055/package.json#L38 or https://github.com/mui/material-ui/blob/a705e1f15075b2deb59263868bfa7b1d9f84cdd4/package.json#L75 seems better.

we should probably find a way to avoid having multiple copies of it.

Oh yeah, once we remove babel alias. I'm not worried about this, I think it's about copying the Base UI repo or Material UI repo. They should get this right. We shouldn't have to think about this in the MUI X repo.

Oh yeah, once we remove babel alias. I'm not worried about this, I think it's about copying the Base UI repo or Material UI repo. They should get this right. We shouldn't have to think about this in the MUI X repo.

Sorry I don't understand what you mean there. Could we create an aliases.js file at the root to avoid repeating the alias list?

oliviertassinari · 2025-04-27T00:49:02Z

test/regressions/package.json

  "private": true,
  "type": "module",
-  "scripts": {


It seems simpler to have all the actions at the root. I don't actually mind actually, but we might as well copy the references (Base UI, Material UI).

oliviertassinari · 2025-04-27T00:49:27Z

package.json

@@ -43,8 +43,11 @@
    "test:e2e": "pnpm run release:build && cd test/e2e && pnpm run start",
    "test:e2e-website": "npx playwright test test/e2e-website --config test/e2e-website/playwright.config.ts",
    "test:e2e-website:dev": "PLAYWRIGHT_TEST_BASE_URL=http://localhost:3001 npx playwright test test/e2e-website --config test/e2e-website/playwright.config.ts",
-    "test:regressions": "pnpm run release:build && cd test/regressions && pnpm run start",
-    "test:regressions:dev": "cd test/regressions && pnpm run start",


test:regressions:dev doesn't work

oliviertassinari · 2025-04-28T01:09:10Z

package.json

-    "test:regressions:dev": "cd test/regressions && pnpm run start",
+    "test:regressions": "cross-env NODE_ENV=production pnpm test:regressions:build && concurrently --success first --kill-others \"pnpm test:regressions:run\" \"pnpm test:regressions:server\"",
+    "test:regressions:build": "cross-env TEST_BUILD=true vite build --config test/regressions/vite.config.js",
+    "test:regressions:dev": "pnpm test:regressions:build && pnpm test:regressions:server",


I would want to use this here:

Suggested change

"test:regressions:dev": "pnpm test:regressions:build && pnpm test:regressions:server",

"test:regressions:dev": "cross-env TEST_BUILD=true vite --config test/regressions/vite.config.js --port 5001",

but Vite seems unable to build properly in dev mode compared to webpack, so falling back to this 🙃. Sad, I don't understand.

oliviertassinari · 2025-04-28T01:15:41Z

test/regressions/vite.config.js

+      '@mui/x-data-grid': path.resolve(import.meta.dirname, '../../packages/x-data-grid/src'),
+      '@mui/x-data-grid-generator': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-generator/src',
+      ),
+      '@mui/x-data-grid-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-pro/src',
+      ),
+      '@mui/x-data-grid-premium': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-data-grid-premium/src',
+      ),
+      '@mui/x-date-pickers': path.resolve(import.meta.dirname, '../../packages/x-date-pickers/src'),
+      '@mui/x-date-pickers-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-date-pickers-pro/src',
+      ),
+      '@mui/x-charts': path.resolve(import.meta.dirname, '../../packages/x-charts/src'),
+      '@mui/x-charts-pro': path.resolve(import.meta.dirname, '../../packages/x-charts-pro/src'),
+      '@mui/x-tree-view': path.resolve(import.meta.dirname, '../../packages/x-tree-view/src'),
+      '@mui/x-tree-view-pro': path.resolve(
+        import.meta.dirname,
+        '../../packages/x-tree-view-pro/src',
+      ),
+      '@mui/x-license': path.resolve(import.meta.dirname, '../../packages/x-license/src'),
+      '@mui/x-telemetry': path.resolve(import.meta.dirname, '../../packages/x-telemetry/src'),
+      '@mui/x-internals': path.resolve(import.meta.dirname, '../../packages/x-internals/src'),
+      '@mui/material-nextjs': path.resolve(
+        import.meta.dirname,
+        '../../node_modules/@mui/monorepo/packages/mui-material-nextjs/src',
+      ),
+      docs: path.resolve(import.meta.dirname, '../../node_modules/@mui/monorepo/docs'),


Without this, we have to build the whole project and have it in watch mode to debug/run the visual regression tests, which feels super slow (+200s on my end). Too slow to be usable in practice. #17584

https://github.com/mui/base-ui/blob/a7451a08424f12d913c8355cccf3274ef5f3e055/package.json#L38 or https://github.com/mui/material-ui/blob/a705e1f15075b2deb59263868bfa7b1d9f84cdd4/package.json#L75 seems better.

we should probably find a way to avoid having multiple copies of it.

Oh yeah, once we remove babel alias. I'm not worried about this, I think it's about copying the Base UI repo or Material UI repo. They should get this right. We shouldn't have to think about this in the MUI X repo.

oliviertassinari · 2025-04-28T01:18:40Z

package.json

Ok, a variant of this PR: #17583, but I don't really see the value, having the same depends between the different test env seems OK.

github-actions · 2025-05-05T06:35:26Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2025-06-11T03:29:37Z

This pull request has been inactive for 30 days. Please remove the stale label or leave a comment to keep it open. Otherwise, it will be closed in 15 days.

github-actions · 2025-06-26T03:30:18Z

This pull request has been closed due to 15 days of inactivity after being marked stale.

oliviertassinari force-pushed the fix-regression branch from 634d792 to e584446 Compare April 26, 2025 23:33

oliviertassinari changed the title ~~Fix regression~~ [test] Sync regression test layout with Base UI / Material UI Apr 26, 2025

[test] Sync regression test layout with Base UI / Material UI

bd67283

oliviertassinari force-pushed the fix-regression branch from e584446 to bd67283 Compare April 26, 2025 23:53

oliviertassinari added test type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. labels Apr 27, 2025

oliviertassinari mentioned this pull request Apr 27, 2025

[core] Set default regression port mui/base-ui#1786

Merged

fix

e326205

oliviertassinari force-pushed the fix-regression branch from 0f97e20 to e326205 Compare April 27, 2025 00:19

romgrk reviewed Apr 27, 2025

View reviewed changes

oliviertassinari marked this pull request as draft April 27, 2025 14:34

oliviertassinari added 3 commits April 28, 2025 02:54

avoid distractions

2da00b5

simplify

e12b23c

ready

60a3728

oliviertassinari force-pushed the fix-regression branch from b68d266 to 60a3728 Compare April 28, 2025 01:15

This was referenced Apr 28, 2025

[test] Sync regression test layout with Base UI / Material UI v2 #17583

Draft

[test] Sync regression test layout with Base UI / Material UI v3 #17584

Draft

oliviertassinari commented Apr 28, 2025

View reviewed changes

oliviertassinari added the type: bug A bug or unintended behavior in the components. label Apr 28, 2025

oliviertassinari marked this pull request as ready for review April 28, 2025 01:35

oliviertassinari removed the type: regression A bug that reintroduces previously resolved issues or breaks existing functionality. label Apr 28, 2025

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 5, 2025

github-actions bot added the stale Inactive for 7 days (issues) or 30 days (PRs); closed after 5 or 15 more days if no update. label Jun 11, 2025

github-actions bot closed this Jun 26, 2025

	"test:regressions:dev": "pnpm test:regressions:build && pnpm test:regressions:server",
	"test:regressions:dev": "cross-env TEST_BUILD=true vite --config test/regressions/vite.config.js --port 5001",

Uh oh!

[test] Sync regression test layout with Base UI / Material UI #17564

[test] Sync regression test layout with Base UI / Material UI #17564

Uh oh!

Conversation

oliviertassinari commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mui-bot commented Apr 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

romgrk Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romgrk Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

romgrk Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

romgrk Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

romgrk Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oliviertassinari Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 5, 2025

Uh oh!

github-actions bot commented Jun 11, 2025

Uh oh!

github-actions bot commented Jun 26, 2025

Uh oh!

Uh oh!

oliviertassinari commented Apr 26, 2025 •

edited

Loading

github-actions bot commented Apr 26, 2025 •

edited

Loading

mui-bot commented Apr 26, 2025 •

edited

Loading

romgrk Apr 27, 2025 •

edited

Loading

oliviertassinari Apr 28, 2025 •

edited

Loading

oliviertassinari Apr 28, 2025 •

edited

Loading

oliviertassinari Apr 27, 2025 •

edited

Loading

oliviertassinari Apr 28, 2025 •

edited

Loading

oliviertassinari Apr 28, 2025 •

edited

Loading